[inner loop poc] debug workspace window #15490

akosyakov · 2022-12-22T20:56:32Z

Description

This PR introduces an experimental approach to debug gitpod workspace configuration. To be tested internally first, this will allow testing .gitpod.yml and .gitpod.Dockerfile within a workspace without the need to git push such files.

For demo, see an internal thread.

The debug location:

does not use blobserve to serve static content, but serve directly from the workspace
does not have access to sensitive cookies like Gitpod cookie

This PR as well fixes service VS Code production built from sources (not blobserve) and align serving of webviews for production (workspace locations) and in dev mode (port location).

Related Issue(s)

Fixes #

How to test

Test for regressions

Start VS Code stable, check that everything works and the inner loop actions are NOT available.

Test for feature flag

Start VS Code latest, check that everything works and the inner loop actions are NOT available.
Enable the feature flag for a user.
Start VS Code latest, check that everything works and the inner loop actions are available.

Release Notes

NONE

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

werft-gitpod-dev-com · 2022-12-22T20:56:44Z

started the job as gitpod-build-ak-new-window.2 because the annotations in the pull request description changed
(with .werft/ from main)

werft-gitpod-dev-com · 2022-12-22T20:56:46Z

started the job as gitpod-build-ak-new-window.3 because the annotations in the pull request description changed
(with .werft/ from main)

akosyakov · 2022-12-23T17:32:00Z

/werft run

👍 started the job as gitpod-build-ak-new-window.21
(with .werft/ from main)

kylos101 · 2022-12-23T18:21:58Z

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-ak-new-window.22
(with .werft/ from main)

akosyakov · 2022-12-26T12:11:54Z

/werft run recreate-vm=true

👍 started the job as gitpod-build-ak-new-window.34
(with .werft/ from main)

akosyakov · 2022-12-26T22:41:01Z

/werft run recreate-vm=true

👍 started the job as gitpod-build-ak-new-window.40
(with .werft/ from main)

andreafalzetti · 2023-01-03T19:07:08Z

/werft run recreate-preview

👍 started the job as gitpod-build-ak-new-window.52
(with .werft/ from main)

Siddhant-K-code · 2023-01-05T13:49:48Z

@akosyakov you need to squash all commits to one (because GitGuardian) with latest main pull. Internal Discussion

akosyakov · 2023-01-05T13:51:21Z

@Siddhant-K-code There is only one commit 🤔

Siddhant-K-code · 2023-01-05T13:52:06Z

@Siddhant-K-code There is only one commit 🤔

GitGuardian is failing due to this PR

akosyakov · 2023-01-05T15:05:13Z

@felladrin commented:

I started a workspace in the Preview Environment, which had image: mcr.microsoft.com/playwright:focal in the .gitpod.yml, then when clicking the build/test I got the following:
Executing task: gp-run --all-commands=false 

Error: no supported container runtime detected
Should we hide the buttons if we don't find a container runtime in the user's current image?

I think it is fine, it means a user should install it.

felladrin

Reviewed and tested! ✅

When running without the feature flag or running VS Code Stable, it doesn't show the new actions for .gitpod.yml. After activating the feature for my user, all buttons were there and worked as described. And I didn't see any regression during the tests.

install/installer/pkg/components/ide-service/ide_config_configmap.go

kylos101 · 2023-01-05T21:13:50Z

@jenting could you review this PR? There are ws-proxy changes, when we filter this PR for code owner files? 🙏

jenting

LGTM in general

components/ws-proxy/pkg/proxy/routes.go

components/ws-proxy/pkg/proxy/workspacerouter.go

iQQBot · 2023-01-06T09:46:58Z

/werft run

👍 started the job as gitpod-build-ak-new-window.59
(with .werft/ from main)

akosyakov · 2023-01-06T10:04:49Z

components/gitpod-protocol/src/util/gitpod-host-url.ts

@@ -16,10 +16,10 @@ const baseWorkspaceIDRegex =
    "(([a-f][0-9a-f]{7}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})|([0-9a-z]{2,16}-[0-9a-z]{2,16}-[0-9a-z]{8,11}))";

 // this pattern matches v4 UUIDs as well as the new generated workspace ids (e.g. pink-panda-ns35kd21)
-const workspaceIDRegex = RegExp(`^${baseWorkspaceIDRegex}$`);
+const workspaceIDRegex = RegExp(`^(?:debug-)?${baseWorkspaceIDRegex}$`);


@geropl Could someone have a look please? 🙏

it is rather only this change for webapp. It does not really affect anythin besides supervisor frontend as far as I aware.

Debug workspaces are started within a regular workspace, not via Gitpod itself.

Debug workspaces are started within a regular workspace, not via Gitpod itself.

That would be an excellent doc comment on the debugWorkspace property below.

Co-authored-by: Anton Kosyakov <anton@gitpod.io> Co-authored-by: Victor Nogueira <victor@gitpod.io> Co-authored-by: Andrea Falzetti <andrea@gitpod.io>

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/L labels Dec 22, 2022

akosyakov force-pushed the ak/new_window branch from 77a5ead to 2cebccc Compare December 22, 2022 21:48

roboquat added size/XL and removed size/L labels Dec 23, 2022

akosyakov changed the title ~~[supervisor] make it compatible with run-gp~~ [inner loop poc] debug workspace Dec 23, 2022

akosyakov changed the title ~~[inner loop poc] debug workspace~~ [inner loop poc] debug workspace window Dec 23, 2022

akosyakov mentioned this pull request Dec 23, 2022

[supervisor] make it compatible with run-gp #15480

Closed

4 tasks

akosyakov force-pushed the ak/new_window branch from 202496c to 1851499 Compare December 23, 2022 15:11

roboquat added size/XXL and removed size/XL labels Dec 25, 2022

akosyakov force-pushed the ak/new_window branch 2 times, most recently from 50f0ee9 to c127011 Compare December 25, 2022 22:47

akosyakov force-pushed the ak/new_window branch 3 times, most recently from 56477f3 to 330a901 Compare December 26, 2022 22:21

akosyakov force-pushed the ak/new_window branch 4 times, most recently from d51162d to 909de18 Compare December 27, 2022 23:55

andreafalzetti force-pushed the ak/new_window branch 2 times, most recently from 7f1618a to ff46269 Compare January 3, 2023 17:53

github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jan 5, 2023

akosyakov force-pushed the ak/new_window branch from 731d16d to aefc560 Compare January 5, 2023 13:46

This comment was marked as outdated.

Sign in to view

felladrin approved these changes Jan 5, 2023

View reviewed changes

felladrin reviewed Jan 5, 2023

View reviewed changes

install/installer/pkg/components/ide-service/ide_config_configmap.go Show resolved Hide resolved

jenting reviewed Jan 6, 2023

View reviewed changes

components/ws-proxy/pkg/proxy/routes.go Outdated Show resolved Hide resolved

components/ws-proxy/pkg/proxy/workspacerouter.go Show resolved Hide resolved

akosyakov force-pushed the ak/new_window branch 2 times, most recently from 641d824 to 7de88b2 Compare January 6, 2023 08:37

akosyakov commented Jan 6, 2023

View reviewed changes

iQQBot force-pushed the ak/new_window branch from 7de88b2 to 291140a Compare January 6, 2023 12:30

[gp-run] experimental workspace config debug mode

f4276a0

Co-authored-by: Anton Kosyakov <anton@gitpod.io> Co-authored-by: Victor Nogueira <victor@gitpod.io> Co-authored-by: Andrea Falzetti <andrea@gitpod.io>

iQQBot force-pushed the ak/new_window branch from 291140a to f4276a0 Compare January 6, 2023 16:54

akosyakov requested a review from jenting January 6, 2023 18:39

svenefftinge approved these changes Jan 6, 2023

View reviewed changes

jenting approved these changes Jan 9, 2023

View reviewed changes

roboquat merged commit 6976960 into main Jan 9, 2023

roboquat deleted the ak/new_window branch January 9, 2023 05:32

roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production labels Jan 9, 2023

Siddhant-K-code mentioned this pull request Jan 9, 2023

Epic: Improve versioning and rollout of workspace images #10683

Open

6 tasks

roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jan 11, 2023

andreafalzetti mentioned this pull request Jan 13, 2023

[Code][Inner Loop] Add Codelens for launching debug workspace window #15735

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[inner loop poc] debug workspace window #15490

[inner loop poc] debug workspace window #15490

akosyakov commented Dec 22, 2022 •

edited

Loading

werft-gitpod-dev-com bot commented Dec 22, 2022

werft-gitpod-dev-com bot commented Dec 22, 2022

akosyakov commented Dec 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Dec 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Dec 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Dec 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

andreafalzetti commented Jan 3, 2023 •

edited by werft-gitpod-dev-com bot

Loading

This comment was marked as outdated.

Siddhant-K-code commented Jan 5, 2023 •

edited

Loading

akosyakov commented Jan 5, 2023 •

edited by werft-gitpod-dev-com bot

Loading

Siddhant-K-code commented Jan 5, 2023 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Jan 5, 2023 •

edited by felladrin

Loading

felladrin left a comment

kylos101 commented Jan 5, 2023

jenting left a comment

iQQBot commented Jan 6, 2023 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov Jan 6, 2023

svenefftinge Jan 6, 2023

[inner loop poc] debug workspace window #15490

[inner loop poc] debug workspace window #15490

Conversation

akosyakov commented Dec 22, 2022 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

Werft options:

werft-gitpod-dev-com bot commented Dec 22, 2022

werft-gitpod-dev-com bot commented Dec 22, 2022

akosyakov commented Dec 23, 2022 • edited by werft-gitpod-dev-com bot Loading

kylos101 commented Dec 23, 2022 • edited by werft-gitpod-dev-com bot Loading

akosyakov commented Dec 26, 2022 • edited by werft-gitpod-dev-com bot Loading

akosyakov commented Dec 26, 2022 • edited by werft-gitpod-dev-com bot Loading

andreafalzetti commented Jan 3, 2023 • edited by werft-gitpod-dev-com bot Loading

This comment was marked as outdated.

Siddhant-K-code commented Jan 5, 2023 • edited Loading

akosyakov commented Jan 5, 2023 • edited by werft-gitpod-dev-com bot Loading

Siddhant-K-code commented Jan 5, 2023 • edited by werft-gitpod-dev-com bot Loading

akosyakov commented Jan 5, 2023 • edited by felladrin Loading

felladrin left a comment

Choose a reason for hiding this comment

kylos101 commented Jan 5, 2023

jenting left a comment

Choose a reason for hiding this comment

iQQBot commented Jan 6, 2023 • edited by werft-gitpod-dev-com bot Loading

akosyakov Jan 6, 2023

Choose a reason for hiding this comment

svenefftinge Jan 6, 2023

Choose a reason for hiding this comment

akosyakov commented Dec 22, 2022 •

edited

Loading

akosyakov commented Dec 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Dec 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Dec 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Dec 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

andreafalzetti commented Jan 3, 2023 •

edited by werft-gitpod-dev-com bot

Loading

Siddhant-K-code commented Jan 5, 2023 •

edited

Loading

akosyakov commented Jan 5, 2023 •

edited by werft-gitpod-dev-com bot

Loading

Siddhant-K-code commented Jan 5, 2023 •

edited by werft-gitpod-dev-com bot

Loading

akosyakov commented Jan 5, 2023 •

edited by felladrin

Loading

iQQBot commented Jan 6, 2023 •

edited by werft-gitpod-dev-com bot

Loading