Skip to content

Revert monospace font configuration #16047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jan 26, 2023

Description

Revert changes in #15936, see relevant discussion (internal). Cc @svenefftinge @AlexTugarev

Sorry @filiptronicek @geropl ! 🍊 🍊

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team January 26, 2023 12:35
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jan 26, 2023
@gtsiolis gtsiolis force-pushed the gt/revert-monospace-configuration branch from 8f5e652 to ca5fccb Compare January 26, 2023 12:38
@@ -64,7 +64,16 @@ module.exports = {
"Segoe UI Symbol",
"Noto Color Emoji",
],
mono: ["JetBrains Mono", "SF Mono", "Monaco", "Inconsolata", "Fira Mono", "Droid Sans Mono", "Source Code Pro", "monospace"],
mono: [
"JetBrains Mono",
Copy link
Contributor Author

@gtsiolis gtsiolis Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the same font as a monospaced font stack option for other existing use cases of the monospaced fonts.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Thanks @gtsiolis for taking care of this 🙏

@roboquat roboquat merged commit 2128412 into main Jan 26, 2023
@roboquat roboquat deleted the gt/revert-monospace-configuration branch January 26, 2023 12:44
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants