Skip to content

Monospaced fonts adoption in the Dashboard #15936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

Monospaced fonts adoption in the Dashboard #15936

merged 1 commit into from
Jan 23, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jan 20, 2023 •
edited
Loading

Description

Continues on the work done in #15397 with adding a standardized font for mono space: JetBrains Mono

Related Issue(s)

Fixes #15443

How to test

Take a look around the dashboard and observe all branch names, environment variables, commit hashes and IDE versions in monospace.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all-ci
  • /werft no-test
    Run Leeway with --dont-test
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@filiptronicek filiptronicek requested a review from a team January 20, 2023 23:40
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-filiptronicek-begin-the-adoption-15443.2 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jan 20, 2023
@filiptronicek filiptronicek self-assigned this Jan 20, 2023
@filiptronicek filiptronicek force-pushed the filiptronicek/begin-the-adoption-15443 branch 2 times, most recently from 3bbd34a to 31597bb Compare January 21, 2023 09:13
@filiptronicek filiptronicek force-pushed the filiptronicek/begin-the-adoption-15443 branch from 31597bb to 8014462 Compare January 21, 2023 13:00
geropl
geropl approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but missing context, so summoning @gtsiolis 👋

/hold

@roboquat roboquat merged commit 207436c into main Jan 23, 2023
@roboquat roboquat deleted the filiptronicek/begin-the-adoption-15443 branch January 23, 2023 08:29
@geropl
Copy link
Member

geropl commented Jan 23, 2023

Ughh, the race went out the wrong way... 🙈
@gtsiolis Might still make sense if you take a look here ☝️

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 23, 2023
@gtsiolis gtsiolis mentioned this pull request Jan 26, 2023
Merged
8 tasks
@gtsiolis gtsiolis mentioned this pull request Mar 16, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@filiptronicek filiptronicek

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production do-not-merge/hold release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Begin the adoption of monospaced fonts in the Dashboard
3 participants
@filiptronicek @geropl @roboquat