Skip to content

Add fonts #16882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add fonts #16882

wants to merge 1 commit into from

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Mar 16, 2023

Description

🚧 WIP—Playground for adding and serving fonts locally, instead on relying on the system font stack, see relevant diff below:

This is adding Inter 3.19.

fontFamily: {
sans: [
"Inter",
"system-ui",
"-apple-system",
"BlinkMacSystemFont",
"Segoe UI",
"Roboto",
"Helvetica Neue",
"Arial",
"Noto Sans",
"sans-serif",
"Apple Color Emoji",
"Segoe UI Emoji",
"Segoe UI Symbol",
"Noto Color Emoji",
],
mono: [
"JetBrains Mono",
"SF Mono",
"Monaco",
"Inconsolata",
"Fira Mono",
"Droid Sans Mono",
"Source Code Pro",
"monospace",
],
},

Following up from #15936 and #15443.

Related Issue(s)

Fixes #

How to test

Release Notes

Add fonts locally

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@stale
Copy link

stale bot commented Apr 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 2, 2023
@stale stale bot closed this Apr 7, 2023
@gtsiolis gtsiolis reopened this Apr 7, 2023
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 7, 2023
@stale
Copy link

stale bot commented Apr 26, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 26, 2023
@stale stale bot closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants