Skip to content

Org Settings and Modal alert updates #16883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2023
Merged

Org Settings and Modal alert updates #16883

merged 10 commits into from
Mar 20, 2023

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Mar 16, 2023

Description

  • Swap org settings page heading back so it's the same for all pages (discussed here)

  • Updated SSO & Git Auth page headings for consistency

image

image

  • SSO client api error message details included in Modal alerts

image

SSO clients list items updated so issuer URL is more prominent than ID.
image

Modal Footer Alert improvements

Made some updates so modal alerts can be closeable, and animate in if so. If they're not closeable they render statically between the modal body and footer.

Non-Closeable Closeable
image Screen Recording 2023-03-17 at 5 33 39 PM (it's much smoother/quicker live)

How to test

Preview Env: https://bmh-org-sef32ac21e40.preview.gitpod-dev.com/workspaces

  • Create an Org
  • Visit Org Settings - verify main heading is Org Settings for each page
  • Create an SSO client with something like test.com for the issuer url.
  • Verify the error alert includes api response details
  • Create a Git Auth configuration.
  • Verify the Activation warning shows up in the modal if you go back in to edit it.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-bmh-org-settings-followups.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/L and removed size/M labels Mar 16, 2023
@roboquat roboquat added size/XL and removed size/L labels Mar 17, 2023
@selfcontained selfcontained marked this pull request as ready for review March 17, 2023 23:51
@selfcontained selfcontained requested a review from a team March 17, 2023 23:51
@selfcontained selfcontained requested a review from gtsiolis as a code owner March 17, 2023 23:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 17, 2023
@selfcontained selfcontained changed the title simplify oidc client list view Org Settings and Modal alert updates Mar 18, 2023
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/hold in case you want another review

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 7b7c729 into main Mar 20, 2023
@roboquat roboquat deleted the bmh/org-settings-followups branch March 20, 2023 20:51
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants