[server] remove definitely-gp #18278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/remove-definitely-gp
branch
from
13bfed9 to
b5cf792
Compare
|
/unhold |
selfcontained
approved these changes
Jul 13, 2023
roboquat
added
deployed: webapp
csweichel
added a commit
that referenced
this pull request
Jul 19, 2023
This reverts commit 0ea1b3a.
akosyakov
reviewed
Jul 19, 2023
| rev = "master"; | ||
| image.file = dockerfilePath; | ||
| } | ||
| if (!(AdditionalContentContext.is(commit) && commit.additionalFiles[dockerfilePath])) { |
There was a problem hiding this comment.
Can you share context / discussion on this?
There was a problem hiding this comment.
it is Dockerfile from the repo.
There was a problem hiding this comment.
@akosyakov what was the impact to users by having this removed? Would it make sense to introduce a metric and alert to help surface this in the future?
AlexTugarev
reviewed
Jul 19, 2023
| let rev = commit.revision; | ||
| const image = config.image!; | ||
|
|
||
| if (config._origin === "definitely-gp") { |
There was a problem hiding this comment.
I think, only this case should have been removed.
roboquat
pushed a commit
that referenced
this pull request
Jul 19, 2023
svenefftinge
added a commit
that referenced
this pull request
Jul 20, 2023
svenefftinge
added a commit
that referenced
this pull request
Jul 20, 2023
roboquat
pushed a commit
that referenced
this pull request
Jul 20, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the deprecated support for definitely-gp
Related Issue(s)
Fixes #8473
How to test
Start a workspace on something that used to start off a definitely-go config and verify it starts from an inferred default config. E.g.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold