[server] remove definitely-gp #18316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
revert-18306-revert-18278-se/remove-definitely-gp
branch
from
c0396c8 to
9f0b829
Compare
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 5608610903
|
AlexTugarev
approved these changes
Jul 20, 2023
|
We can try with this repo once the VM is up again |
|
I started 2 workspaces using https://revert-183a28a79aab0.preview.gitpod-dev.com/new#https://github.com/gitpod-samples/template-quarkus. No image build to see, but That should be fine then, right? |
|
Yes, thanks for testing /unhold |
roboquat
added
deployed: webapp
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
reviewed
Jul 21, 2023
| @@ -36,25 +35,7 @@ export class ImageSourceProvider { | |||
| let result: WorkspaceImageSource; | |||
|
|
|||
| const imgcfg = config.image; | |||
| if (ExternalImageConfigFile.is(imgcfg)) { | |||
There was a problem hiding this comment.
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
AlexTugarev
added a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the deprecated support for definitely-gp.
Related Issue(s)
Fixes #8473
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold