[code] support previous and current ubuntu LTS

[akosyakov]

What it does

• fix code: support ubuntu lts as a baseline #3832: support previous and current ubuntu LTS by building against 18.04 (previous) as a baseline

How to test

• In both cases that run, scm and ouput view for remote server channel are functional.
• test against ubuntu 18.04: https://akosyakov-code-support-ubuntu-lts-3832.staging.gitpod-dev.com/#https://gitlab.com/tonka3000/simple-cpp-abi-project
• test against ubuntu 20.04: https://akosyakov-code-support-ubuntu-lts-3832.staging.gitpod-dev.com/#https://github.com/gitpod-io/gitpod

[markfirmware]

@akosyakov Will this provide something like

image: gitpod/workspace-18.04-full-vnc

in .gitpod.yml?

I have a vnc use case that needs 18.04 and I would like to see the image maintained at gitpod. (My use case also requires a small update on top of 18.04 which is performed by a sudo in the workspace.)

[akosyakov]

No, it is about building VS Code in such way that it can run on workspace images based on ubuntu 18.04 as well as 20.04. It is not about changing workspace images.

Could you file an issue for your request? I am not sure that it makes sense everything is moving to 20.04 and 18.04 won't be relevant in a year probably.

[jankeromnes]

Taking a look now. 👀

test against ubuntu 18.04: https://akosyakov-code-support-ubuntu-lts-3832.staging.gitpod-dev.com/#https://gitlab.com/tonka3000/simple-cpp-abi-project

Note: This repository currently seems to use 17.10 instead (but it's still a relevant test, since it reproduces #3832):

$ cat /etc/issue
Ubuntu 17.10

[jankeromnes]

/werft run

👍 started the job as gitpod-build-akosyakov-code-support-ubuntu-lts-3832.29

[jankeromnes]

Code looks good and works as advertised. Many thanks @akosyakov! 💯

I've aded a few questions below and in-line, but please feel free to merge as is. ✅

In both cases that run, scm and ouput view for remote server channel are functional.

With both repos, scm works and output view for remote server channel seems to work. It does log a few errors, but I think they're unrelated. Still sharing them here FYI:

[2021-04-22 10:19:20.519] [main] [error] Extension 'hangxingliu.vscode-nginx-conf-hint' not found.
[2021-04-22 10:19:21.582] [main] [error] code server: failed to install intial extensions resolved by Code server: {}
[2021-04-22 10:19:40.242] [main] [error] Error: ENOENT: no such file or directory, stat '/ide/vs/workbench/contrib/output/common/outputLinkComputer.js'

Also, the window channel keeps logging this in a loop (also for both repos):

[2021-04-22 12:24:56.304] [window] [error] Not Found: WorkerScriptLoader.prototype.load/<@https://amaranth-rhinoceros-pxopwqbp.ws-dev.akosyakov-code-support-ubuntu-lts-3832.staging.gitpod-dev.com/out/vs/base/worker/workerMain.js#outputLinkComputer:707:31

[jankeromnes]

Question: Why not 12.22.1? https://nodejs.org/dist/latest-v12.x/

[akosyakov]

I will bump it up with next vscode upgrade in May, ok?

[jankeromnes]

Question: Why re-install Node.js via NVM here (with nvm.sh being quite slow) instead of doing something like this?

COPY --from=node_installer /ide/node /ide/node
ENV PATH="/ide/node/bin:$PATH"

This is unimportant though, as this NVM/Node.js install doesn't seem to be captured in the final FROM scratch image below.

Since this works it's good as is. 👍

[akosyakov]

Just did not think about it