Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: capitalize proper noun Git in dashboard components #6039

Merged
merged 3 commits into from
Nov 2, 2021
Merged

chore: capitalize proper noun Git in dashboard components #6039

merged 3 commits into from
Nov 2, 2021

Conversation

HonkingGoose
Copy link
Contributor

Description

  • Capitalize proper noun Git in dashboard components

Related Issue(s)

Driveby PR, not closing any issue with this.
Retry of PR #5990, let's hope this branch name is short enough. 😄

How to test

  1. Review changes in the PR for correct spelling/capitalization.
  2. Find way to preview dashboard components on a dev server.
  3. Find way to run the tests, to confirm I'm not breaking any Jest snapshots or other test files.

This is my first contribution to the Gitpod program itself.
I did not find any developer documentation on how to run a dev server which shows me the components, so I can verify my changes myself.

Also please review/edit my Release Notes below, I hope this is the correct format.

Release Notes

capitalize proper noun Git in dashboard components

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks again! 💯 Same as #5990 (review)

/lgtm
/approve no-issue
/hold
/werft run

@roboquat
Copy link
Contributor

roboquat commented Oct 5, 2021

LGTM label has been added.

Git tree hash: cf3327f47e75c203f82e881666488002e4e21c60

@jankeromnes jankeromnes removed the request for review from AlexTugarev October 5, 2021 08:34
@iQQBot
Copy link
Contributor

iQQBot commented Oct 5, 2021

@HonkingGoose can you try it?
#6036

@jankeromnes jankeromnes changed the title Git dashboard chore: capitalize proper noun Git in dashboard components Oct 5, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 5, 2021

/werft run

👍 started the job as gitpod-build-git-dashboard-fork.0

@jankeromnes
Copy link
Contributor

/check-cla

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 6, 2021

@meysholdt Please help unblock this really cool Pull Request by stating whether signing a CLA is required or not. 🙂 🙏

@meysholdt
Copy link
Member

hi @HonkingGoose ! Thank you for your contribution! Can you please drop me an email with your name to moritz@gitpod.io? I will check if we have a CLA from you on record, and if we don't, send a CLA to you for signing via DocuSign. Sorry for the inconvenience and please understand a signed CLA is prerequisite for merging PRs in this repository.

@stale
Copy link

stale bot commented Oct 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 18, 2021
@HonkingGoose
Copy link
Contributor Author

hi @HonkingGoose ! Thank you for your contribution! Can you please drop me an email with your name to moritz@gitpod.io? I will check if we have a CLA from you on record, and if we don't, send a CLA to you for signing via DocuSign. Sorry for the inconvenience and please understand a signed CLA is prerequisite for merging PRs in this repository.

Hi @meysholdt,

Do you support signing the CLA with a different email address than the one I use on GitHub?
I use the email privacy feature in GitHub so I don't disclose my real email address by accident.

HonkingGoose

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 22, 2021
@roboquat roboquat added team: webapp Issue belongs to the WebApp team and removed lgtm labels Oct 29, 2021
@JanKoehnlein
Copy link
Contributor

@meysholdt What's the status of the CLA? (See #6039 (comment))

@meysholdt
Copy link
Member

hi @HonkingGoose ,

Do you support signing the CLA with a different email address than the one I use on GitHub?
I use the email privacy feature in GitHub so I don't disclose my real email address by accident.

yes, you can sign using a different email address.
Can you drop me an email to moritz@gitpod.io where you also mention your real name and your GitHub user name? Then I can send you the CLA via DocuSign for signing.

@HonkingGoose
Copy link
Contributor Author

HonkingGoose commented Nov 2, 2021

@meysholdt Check your inbox. 😉

@meysholdt
Copy link
Member

Hi @HonkingGoose, thank you for signing our CLA :)

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

LGTM label has been added.

Git tree hash: 32a18fab30206fe2fd4db726b3a1c1b6ad0620bc

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes, JanKoehnlein

Associated issue: #5990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Nov 2, 2021

/werft run

👍 started the job as gitpod-build-git-dashboard-fork.1

@roboquat roboquat merged commit f56a9f2 into gitpod-io:main Nov 2, 2021
@HonkingGoose HonkingGoose deleted the git-dashboard branch November 2, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants