Skip to content

[dashboard] add develop guide #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

[dashboard] add develop guide #6036

merged 1 commit into from
Oct 14, 2021

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Oct 5, 2021

Description

The best way to develop Gitpod is in gitpod.io, but when we develop dashboard there is no way to test.
because server and proxy check origin and host and ws-proxy delete cookie
use devServer.proxy can bypass it

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

@roboquat roboquat requested a review from laushinka October 5, 2021 07:54
@roboquat roboquat added the size/S label Oct 5, 2021
@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 5, 2021

/assign @jankeromnes

@iQQBot iQQBot mentioned this pull request Oct 5, 2021
Merged
HonkingGoose
HonkingGoose suggested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let the maintainers check the document for technical accuracy. I just noticed some grammar/typo things that I could fix.

@roboquat
Copy link
Contributor

roboquat commented Oct 6, 2021

@HonkingGoose: changing LGTM is restricted to collaborators

In response to this:

I'll let the maintainers check the document for technical accuracy. I just noticed some grammar/typo things that I could fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 6, 2021

thank you for you guidance, and sorry for my bad English @HonkingGoose

HonkingGoose
HonkingGoose reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add newlines here. 😉

@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 6, 2021

Added, you can try this solution to see if it can solve your problem.

@iQQBot @HonkingGoose
[dashboard] make easier to develop and test
7ebdc19 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@iQQBot iQQBot changed the title [dashboard] make easier to develop and test [dashboard] add develop guide Oct 10, 2021
@laushinka laushinka requested review from a team and removed request for laushinka October 14, 2021 12:56
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Oct 14, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4d63f26e113424500d73c2bb7210ac45ef2370b

@JanKoehnlein
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue requirement bypassed by: JanKoehnlein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 14, 2021

Since (515720a) dashboard need upgrade compiler target to es6
Otherwise it will cause
image
this error on develop

I create a PR fix this #6067
@JanKoehnlein

@aledbf
Copy link
Member

aledbf commented Oct 14, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run no-preview

👍 started the job as gitpod-build-pd-add-dashboard-develop-guild-fork.0

@roboquat roboquat merged commit febbc68 into gitpod-io:main Oct 14, 2021
@iQQBot iQQBot deleted the pd/add-dashboard-develop-guild branch October 15, 2021 01:11
@gtsiolis gtsiolis mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

Assignees

@JanKoehnlein JanKoehnlein

@jankeromnes jankeromnes

Labels
approved community-contribution release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iQQBot @roboquat @JanKoehnlein @aledbf @HonkingGoose @gtsiolis @jankeromnes