upgrade typescript compiler target to es6 #6067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
requested review from
aledbf,
AlexTugarev,
jankeromnes,
JanKoehnlein,
laushinka,
mrsimonemms and
rl-gitpod
|
/cc @geropl Could you have a look? The change looks good, but I am not sure I am missing something. |
|
Test ok on self-hosted cluster, you can run werft to test @JanKoehnlein |
|
/werft run 👍 started the job as gitpod-build-pd-upgrade-typescript-to-es6-fork.0 |
geropl
approved these changes
Oct 21, 2021
|
LGTM label has been added. Git tree hash: 49ee3583b85265ef16a4afe66b26876a9552a472
|
|
/approve no-issue |
|
/assign @akosyakov @csweichel |
akosyakov
approved these changes
Oct 21, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, aledbf, geropl Associated issue requirement bypassed by: geropl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade typescript compiler target to es6
it can reduce compile cost and boost performance a little
and fix this problem from dashboard (515720a)
Related Issue(s)
How to test
Release Notes