Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording on new prefixed login/signup #7189

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fix wording on new prefixed login/signup #7189

merged 1 commit into from
Dec 14, 2021

Conversation

championshuttler
Copy link
Contributor

@championshuttler championshuttler commented Dec 12, 2021 •
edited by iQQBot
Loading

Description

Related Issue(s)

Fixes #7188

How to test

Release Notes

NONE

Documentation

@championshuttler
Copy link
Contributor Author

/assign @AlexTugarev

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 13, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-patch-1-fork.6

@gtsiolis gtsiolis self-requested a review December 13, 2021 13:16
gtsiolis
gtsiolis approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @championshuttler! 🎩

Similar to #7187 (review):

  1. Changes looks great. ✔️
  2. I've also triggered a preview environment (deployment) where you can see a deployed version with the changes in this PR, see #7187 (comment). 🌔
  3. Waiting for CLA process to be completed in Improve paragraph accessibility in limits reached modals #7187 (review). 🤝

Approving but holding until the CLA process is complete.

Thanks @iQQBot for the labels in #7189 (comment).

/hold

@roboquat roboquat added the lgtm label Dec 13, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a7d84b5487a64dbafb265da8c18f6d8bfbcce85

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis

Associated issue: #7188

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gtsiolis gtsiolis mentioned this pull request Dec 13, 2021
Closed
@meysholdt
Copy link
Member

Hi Shivam,

I've sent you a CLA via DocuSign. Can you sign it so we can merge this PR?

thank you!

@meysholdt
Copy link
Member

Thx for singing the CLA!

@meysholdt meysholdt added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Dec 14, 2021
@gtsiolis
Copy link
Contributor

/unhold

@roboquat roboquat merged commit 50963a4 into gitpod-io:main Dec 14, 2021
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees

@gtsiolis gtsiolis

Labels
approved cla: accepted ✔️ community-contribution deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wording on new prefixed login/signup
6 participants
@championshuttler @gtsiolis @roboquat @meysholdt @AlexTugarev @iQQBot