Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to 1.64.2 #8141

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Update code to 1.64.2 #8141

merged 1 commit into from
Feb 10, 2022

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Feb 10, 2022

Description

Update code to 1.64.2.

How to test

  • Switch to VS Code Insiders in settings.
  • Start a workspace.
  • Test following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data are sync across workspaces as well as on workspace restart, especially for extensions
    • extensions from .gitpod.yml are not installed as sync
    • extensions installed as sync are actually sync in new workspaces
    • settings should not contain any mentions of MS telemetry
    • websockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded on the PR url
    • test gp open and preview
    • test open in VS Code Desktop, check gp open and preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #8141 (9216e2b) into main (890f04c) will decrease coverage by 4.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8141      +/-   ##
==========================================
- Coverage   15.29%   10.82%   -4.47%     
==========================================
  Files          47       18      -29     
  Lines        4543     1025    -3518     
==========================================
- Hits          695      111     -584     
+ Misses       3789      912    -2877     
+ Partials       59        2      -57     
Flag Coverage Δ
components-gitpod-cli-app 10.82% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/storage.go
installer/pkg/components/ws-manager/configmap.go
components/local-app/pkg/auth/pkce.go
components/ws-daemon/pkg/cpulimit/cfs.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/content/archive.go
installer/pkg/common/common.go
components/ws-daemon/pkg/content/service.go
components/ws-daemon/pkg/internal/session/store.go
components/ws-daemon/pkg/cpulimit/cpulimit.go
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890f04c...9216e2b. Read the comment docs.

@filiptronicek
Copy link
Member Author

filiptronicek commented Feb 10, 2022

/werft run

👍 started the job as gitpod-build-ft-vsc-1.64.2.1

@jeanp413 jeanp413 self-requested a review February 10, 2022 19:21
Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanp413
Copy link
Member

/approve no-issue

@roboquat roboquat merged commit ba8e182 into main Feb 10, 2022
@roboquat roboquat deleted the ft/vsc-1.64.2 branch February 10, 2022 19:22
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants