Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code stable to v1.64.2 #8143

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Update code stable to v1.64.2 #8143

merged 1 commit into from
Feb 11, 2022

Conversation

filiptronicek
Copy link
Member

Description

The releases fixes these issues.
Endgame: microsoft/vscode#142605

How to test

Already tested in #8141 😄 .

Open a workspace (must use stable VS Code) and check the version in the About menu - must be 1.64.2.

Release Notes

Update code to 1.64.2

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #8143 (c778f5a) into main (ba8e182) will decrease coverage by 3.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #8143      +/-   ##
=========================================
- Coverage   11.98%   8.03%   -3.96%     
=========================================
  Files          20      31      +11     
  Lines        1193    2215    +1022     
=========================================
+ Hits          143     178      +35     
- Misses       1046    2034     +988     
+ Partials        4       3       -1     
Flag Coverage Δ
components-gitpod-cli-app 10.82% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.45% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 30.05% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8e182...c778f5a. Read the comment docs.

@jeanp413
Copy link
Member

While testing settings sync was not working for some reason, it did work in the PR were we did the smoke testing, will take a look later today and tomorrow with @filiptronicek

@jeanp413 jeanp413 self-requested a review February 10, 2022 19:48
@jeanp413
Copy link
Member

@filiptronicek I tested this again and settings sync is working just fine, seems it was an external issue not related to the update, I'll go ahead and merge it, let's do the release tomorrow morning

Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 2c1b443 into main Feb 11, 2022
@roboquat roboquat deleted the ft/code-stable-v1.64.2 branch February 11, 2022 02:17
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants