Skip to content

[dashboard] Ensure we fetch IDEOptions onload #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 14, 2022

Description

Follow up for #8125, specifically this comment.

Related Issue(s)

Context: #8125

How to test

  • start workspace in tab 1
  • open dashboard in tab 2
  • stop workspace from tab 2
  • change IDE settings and set local IDE
  • start workspace in tab 2
  • note how tab 1 shows IDEoptions now

Release Notes

NONE

Documentation

@geropl geropl requested a review from a team February 14, 2022 11:17
@geropl geropl requested a review from akosyakov February 14, 2022 11:17
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #8188 (0fa9200) into main (a48e177) will decrease coverage by 16.99%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8188       +/-   ##
===========================================
- Coverage   28.17%   11.17%   -17.00%     
===========================================
  Files          41       18       -23     
  Lines        3478      993     -2485     
===========================================
- Hits          980      111      -869     
+ Misses       2443      880     -1563     
+ Partials       55        2       -53     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-ws-proxy-app ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/render.go
components/ws-proxy/pkg/proxy/workspacerouter.go
...staller/pkg/components/ws-manager/networkpolicy.go
components/ws-proxy/pkg/proxy/routes.go
components/ws-proxy/pkg/proxy/config.go
installer/pkg/components/ws-manager/rolebinding.go
installer/pkg/common/ca.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/common/common.go
installer/pkg/components/ws-manager/deployment.go
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48e177...0fa9200. Read the comment docs.

@geropl
Copy link
Member Author

geropl commented Feb 14, 2022

/hold

not ready yet.. 🙄

@geropl
Copy link
Member Author

geropl commented Feb 15, 2022

Closing in favor of issue: #8226

@geropl geropl closed this Feb 15, 2022
@geropl geropl deleted the gpl/dont-autostart-ideoptions branch April 14, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants