[supervisor] Ensure we fetch IDEOptions/desktopIDEConfig on re-start

[geropl]

So far we set dekstopIDEConfig and IDEOptions onload. With the recent change away from auto-reload behavior this does no longer show "Open in < desktopIDE >" in cases where:

• you open a workspace in tab 1
• stop it in tab 2 (dashboard, for example)
• re-start it in tab 2 (dashboard, for example)

We should see

but instead see this:

The dashboard change is quite straight forward. In supervisor-frontend we'd need to re-fetch the desktopIDEConfig on re-start as well.

/cc @akosyakov

[geropl]

This might also be the cause an issue where we do not reveal the IDE of a running workspace after the tab lost focus on laptop suspension (issue):

• we now do not auto-start if runsInFrame
• but we have a special case for revealing for the first time a workspace becomes RUNNING
• this breaks for re-started workspaces or laptop suspenion

I think we need to change the supervisor index to always:

• reveal (RUNNING x browser)
• show recent IDE options (RUNNING x desktopIDE)
  not just the "first time we see RUNNING after onload".

Internal discussion: slack

[loujaybee]

Thanks @geropl — given that this looks to be a smallish fix, let's pull into scheduled. 🙏

[akosyakov]

@geropl I thought we fixed it already 🤔 ?

[geropl]

@akosyakov We only fixed the retrieval of IDEOptions. For supervisor frontend there are 2 things left (cmp esp. the comment abo ve):

• In supervisor-frontend we'd need to re-fetch the desktopIDEConfig on re-start as well

• I think we need to change the supervisor index to always:

  reveal (RUNNING x browser)
  show recent IDE options (RUNNING x desktopIDE)
  not just the "first time we see RUNNING after onload".

[geropl]

@loujaybee just popped up again yesterday on slack.

[akosyakov]

@mustard-mh Can you have a look please? 🙏

[mustard-mh]

We only update ideStatus in supervisor/frontend when ideReady, now the most direct solution is to listen to some other phase and re-listen ideReady. But this is not smart, because we don't know what phases need to wait for ideReady again, and if those phases may be missed due to other situations.

So I think the best ways to do this are

1. Pass IDE configuration of current instance when the instance is updated. (but it lose some args like link etc, this can only generate by supervisor
2. Or use event for ideReady to make ready multiple times?
3. Refresh(or re-ideReady) the whole web page when instance-id changed? 👍

Way 1\2 above will change a lot. What do you think?

cc @geropl @akosyakov

[mustard-mh]

I updated comment above, in case you missed it

[mustard-mh]

So far we set dekstopIDEConfig and IDEOptions onload.

Thanks for guide here👍, I really don't know supervisor/frontend before