Add env var name/value length validation

[randomir]

Redo #8046, this time with shorter branch name that werft can digest.

Fixes #8045.

Release Notes

Add user environment variable name length and value length validation in settings UI modal.

[jankeromnes]

Thanks a lot for making Werft happy!

CLA is still in progress: #8046 (comment)

/werft run

👍 started the job as gitpod-build-env-var-len-validation-fork.0

[jankeromnes]

Thank you again for this fix @randomir!

The code changes look good and work as advertized. 🎯 I've also added a few minor thoughts in-line.

Adding a manual hold on the auto-merger until the CLA is confirmed:

/hold

[randomir]

Thanks @jankeromnes for the quick review. Now we wait for the CLA... 📜

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[geropl]

@meysholdt Any updates wrt the CLA? (pinged because previous comments: here and here)

[meysholdt]

I've pinged them again via email about the CLA.

[jankeromnes]

Still looks good to me 🎉 😁

[jankeromnes]

/werft run

👍 started the job as gitpod-build-env-var-len-validation-fork.1

[codecov]

Codecov Report

Merging #8248 (9cc9a32) into main (a567595) will increase coverage by 3.51%.
The diff coverage is n/a.

❗ Current head 9cc9a32 differs from pull request most recent head 72ad89c. Consider uploading reports for the commit 72ad89c to get more accurate results

@@            Coverage Diff            @@
##            main    #8248      +/-   ##
=========================================
+ Coverage   7.34%   10.86%   +3.51%     
=========================================
  Files         32       18      -14     
  Lines       2234     1022    -1212     
=========================================
- Hits         164      111      -53     
+ Misses      2067      909    -1158     
+ Partials       3        2       -1     

Flag	Coverage Δ
components-gitpod-cli-app	10.86% <ø> (-0.32%)	⬇️
install-installer-raw-app	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/gitpod-cli/cmd/credential-helper.go	5.58% <0.00%> (-1.09%)	⬇️
...nstall/installer/pkg/components/ws-manager/role.go
...l/installer/pkg/components/ws-manager/configmap.go
install/installer/pkg/common/render.go
install/installer/pkg/common/common.go
install/installer/pkg/common/ca.go
install/installer/pkg/common/storage.go
install/installer/pkg/common/display.go
.../installer/pkg/components/ws-manager/deployment.go
install/installer/pkg/common/objects.go
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[geropl]

@jankeromnes assigning you because you last approved 😉

[geropl]

Closing this for now, as we're waiting for a respond regarding CLA. We can always re-open. 🙏

[meysholdt]

we got the CLA signed with D-Wave!

[randomir]

I'll rebase shortly.

[gtsiolis]

/werft run

👍 started the job as gitpod-build-env-var-len-validation-fork.2
(with .werft/ from main)

[jankeromnes]

Many thanks for going through the long CLA process and for rebasing this PR!

Also, thanks George for triggering the new Werft job!

Re-approved and good to go 🚀

[randomir]

Thanks @jankeromnes and @gtsiolis. Sorry it took longer than expected to get the CLA approved. Luckily, it's a one-off thing. 😄

[jankeromnes]

/unhold

[jankeromnes]

Thanks a lot for improving Gitpod! 💯 🙏