Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jb: configure SDK workaround #8406

Merged
merged 1 commit into from
Feb 23, 2022
Merged

jb: configure SDK workaround #8406

merged 1 commit into from
Feb 23, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 23, 2022

Description

As for now IntelliJ cannot apply JDK automatically to detected projects. This PR adds a workaround which will configure a project sdk on startup if it is not configured.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #8406 (dbf4a44) into main (a87a1c8) will decrease coverage by 3.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8406      +/-   ##
==========================================
- Coverage   14.55%   11.17%   -3.38%     
==========================================
  Files          51       18      -33     
  Lines        4878      993    -3885     
==========================================
- Hits          710      111     -599     
+ Misses       4106      880    -3226     
+ Partials       62        2      -60     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/quota/xfs.go
...staller/pkg/components/ws-manager/networkpolicy.go
components/ws-daemon/pkg/content/initializer.go
components/ws-daemon/pkg/cpulimit/cfs.go
...components/ws-manager/unpriviledged-rolebinding.go
components/ws-daemon/pkg/cpulimit/bandwidth.go
components/ws-daemon/pkg/daemon/cache_reclaim.go
...mponents/ws-daemon/pkg/daemon/cgroup_customizer.go
components/ws-daemon/pkg/content/hooks.go
components/ws-daemon/pkg/cpulimit/cpulimit.go
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87a1c8...dbf4a44. Read the comment docs.

@akosyakov akosyakov force-pushed the ak/jb_preconfigure_jdk branch 2 times, most recently from 7e115d2 to 443c08a Compare February 23, 2022 13:17
@akosyakov akosyakov force-pushed the ak/jb_preconfigure_jdk branch from 443c08a to dbf4a44 Compare February 23, 2022 13:25
@akosyakov akosyakov marked this pull request as ready for review February 23, 2022 13:43
@akosyakov akosyakov requested a review from a team February 23, 2022 13:43
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core reviewed and tested! ✅

No sign of popup about configuring SDK in any of the projects! 🎉

@roboquat roboquat merged commit 0f1aaa7 into main Feb 23, 2022
@roboquat roboquat deleted the ak/jb_preconfigure_jdk branch February 23, 2022 13:54
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants