Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jb: auto preconfigure module SDK as well #8415

Merged
merged 1 commit into from
Feb 23, 2022
Merged

jb: auto preconfigure module SDK as well #8415

merged 1 commit into from
Feb 23, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 23, 2022

Description

It is a follow-up of #8406. It turned out that configuring SDK on project level is not enough, depending on timing module SDK will inherit it or not. This PR listeners to new modules and configures them as well.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #8415 (b5b2360) into main (0f1aaa7) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8415      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1aaa7...b5b2360. Read the comment docs.

@akosyakov
Copy link
Member Author

@felladrin How to test section had wrong links from the previous PR, i updated it now.

Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved! ✅

Both projects worked as described!

@mustard-mh
Copy link
Contributor

What does "smartness is available" means?

For me, the code hints work fine, but the format does not remove useless imports. Is that correct?

@akosyakov
Copy link
Member Author

For me, the code hints work fine, but the format does not remove useless imports. Is that correct?

More like all links are resolved, for useless imports try organize imports...

@roboquat roboquat merged commit 9951954 into main Feb 23, 2022
@roboquat roboquat deleted the ak/jb_module_sdk branch February 23, 2022 16:03
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants