-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jb: auto preconfigure module SDK as well #8415
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8415 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@felladrin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved! ✅
Both projects worked as described!
What does "smartness is available" means? For me, the code hints work fine, but the format does not remove useless imports. Is that correct? |
More like all links are resolved, for useless imports try |
Description
It is a follow-up of #8406. It turned out that configuring SDK on project level is not enough, depending on timing module SDK will inherit it or not. This PR listeners to new modules and configures them as well.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation