Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Further disambiguate 'Team Plans' vs 'Teams' based on user feedback (title, button, invite modal) #8563

Closed
wants to merge 1 commit into from
Closed

[dashboard] Further disambiguate 'Team Plans' vs 'Teams' based on user feedback (title, button, invite modal) #8563

wants to merge 1 commit into from

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Mar 3, 2022 •
edited
Loading

Description

Further disambiguate 'Team Plans' vs 'Teams' based on user feedback (title, button, invite modal).

Related Issue(s)

Fixes legacy Team Plans UI by adding the word "plan" in relevant places

How to test

  1. Open /teams
  2. Be slightly less confused

Release Notes

NONE

Documentation

@jankeromnes jankeromnes requested a review from a team March 3, 2022 11:31
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 3, 2022
JanKoehnlein
JanKoehnlein approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Mar 3, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Error The branch name jx-clarify-team-plans is more than 20 character. Please choose a shorter name!

🙄🙄🙄🙄🙄🙄🙄🙄🙄

@jankeromnes jankeromnes closed this Mar 3, 2022
@jankeromnes jankeromnes deleted the jx/clarify-team-plans branch March 3, 2022 11:59
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Mar 3, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@JanKoehnlein Made the branch shorter and re-opened #8565 -- could you please approve again? 😊 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeromnes @JanKoehnlein @roboquat