Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Further disambiguate 'Team Plans' vs 'Teams' based on user feedback (title, button, invite modal) #8565

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

Further disambiguate 'Team Plans' vs 'Teams' based on user feedback (title, button, invite modal).

Related Issue(s)

Fixes legacy Team Plans UI by adding the word "plan" in relevant places

How to test

  1. Open /teams
  2. Be slightly less confused

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8565 (7136007) into main (9de6f13) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8565      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de6f13...7136007. Read the comment docs.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for taking care here. 🙏

@roboquat roboquat merged commit dd2d765 into main Mar 3, 2022
@roboquat roboquat deleted the jx/clrfy-tm-plns branch March 3, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants