-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jetbrains] repo plugins support #8630
Conversation
b86906a
to
0244f47
Compare
Codecov Report
@@ Coverage Diff @@
## main #8630 +/- ##
=========================================
+ Coverage 7.34% 11.17% +3.83%
=========================================
Files 32 18 -14
Lines 2234 993 -1241
=========================================
- Hits 164 111 -53
+ Misses 2067 880 -1187
+ Partials 3 2 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
/werft run 👍 started the job as gitpod-build-ak-jb-repo-plugins.5 |
0244f47
to
6a79e54
Compare
82f79a8
to
f51d1c6
Compare
f51d1c6
to
c4a91e2
Compare
/werft run 👍 started the job as gitpod-build-ak-jb-repo-plugins.11 |
2fa2b23
to
27ac4ba
Compare
I tried with EAP. It is possible to install plugins, but some plugins can freeze the backend startup, so we need a strategy to troubleshoot if we are going forward with it. |
/werft run 👍 started the job as gitpod-build-ak-jb-repo-plugins.15 |
b390ab1
to
08f2329
Compare
/werft run 👍 started the job as gitpod-build-ak-jb-repo-plugins.44 |
82ca477
to
e871c0b
Compare
/werft run with-clean-slate-deployment=true |
e871c0b
to
6ebe4a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clear and the tests ran accordingly to the description.
✅ Test Case 1: Plugin is not available on Stable Backend IDE.
✅ Test Case 2: Plugin is available on EAP Backend IDE.
See .gitpod.yml from the target repo. It contains the plugin saw in the screenshot above:
jetbrains:
plugins:
- com.haulmont.jpab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebApp changes look good!
small and kind nudge: the smaller the PR, and number of teams involved, the easier the review - and quicker the approval. 🧘
Description
This PR allows a user to specify JB plugins in .gitpod.yml, for instance: https://github.com/akosyakov/spring-petclinic/blob/8b4a927182ba75656c5d1fc3931482ea548206bd/.gitpod.yml#L33-L35
Unfortunately it is turned out that stable version of JB backend cannot support it. So this PR additionally introduces conditional building of JB backend plugin against stable and latest versions. For stable version support of repo plugins is disabled, and only enabled for EAP.
Related Issue(s)
fix #6508
How to test
Stable
Latest
Release Notes
Documentation