Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains] repo plugins support #8630

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[jetbrains] repo plugins support #8630

merged 2 commits into from
Apr 7, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 7, 2022

Description

This PR allows a user to specify JB plugins in .gitpod.yml, for instance: https://github.com/akosyakov/spring-petclinic/blob/8b4a927182ba75656c5d1fc3931482ea548206bd/.gitpod.yml#L33-L35

Unfortunately it is turned out that stable version of JB backend cannot support it. So this PR additionally introduces conditional building of JB backend plugin against stable and latest versions. For stable version support of repo plugins is disabled, and only enabled for EAP.

Related Issue(s)

fix #6508

How to test

Stable

Latest

Release Notes

Allow to configure JetBrains plugins in .gitpod.yml

Documentation

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #8630 (40517e4) into main (a567595) will increase coverage by 3.83%.
The diff coverage is n/a.

❗ Current head 40517e4 differs from pull request most recent head 6ebe4a9. Consider uploading reports for the commit 6ebe4a9 to get more accurate results

@@            Coverage Diff            @@
##            main    #8630      +/-   ##
=========================================
+ Coverage   7.34%   11.17%   +3.83%     
=========================================
  Files         32       18      -14     
  Lines       2234      993    -1241     
=========================================
- Hits         164      111      -53     
+ Misses      2067      880    -1187     
+ Partials       3        2       -1     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/common.go
...components/ws-manager/unpriviledged-rolebinding.go
...l/installer/pkg/components/ws-manager/configmap.go
...staller/pkg/components/ws-manager/networkpolicy.go
...installer/pkg/components/ws-manager/rolebinding.go
...nstall/installer/pkg/components/ws-manager/role.go
install/installer/pkg/common/display.go
install/installer/pkg/common/render.go
install/installer/pkg/common/networkpolicies.go
install/installer/pkg/common/ca.go
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@akosyakov
Copy link
Member Author

akosyakov commented Mar 8, 2022

/werft run

👍 started the job as gitpod-build-ak-jb-repo-plugins.5

@akosyakov akosyakov force-pushed the ak/jb_repo_plugins branch from 0244f47 to 6a79e54 Compare March 8, 2022 08:47
@roboquat roboquat added size/XL and removed size/L labels Mar 8, 2022
@akosyakov akosyakov force-pushed the ak/jb_repo_plugins branch 3 times, most recently from 82f79a8 to f51d1c6 Compare March 8, 2022 12:53
@roboquat roboquat added size/L and removed size/XL labels Mar 8, 2022
@akosyakov akosyakov force-pushed the ak/jb_repo_plugins branch from f51d1c6 to c4a91e2 Compare March 8, 2022 13:19
@roboquat roboquat added size/XL and removed size/L labels Mar 8, 2022
@akosyakov
Copy link
Member Author

akosyakov commented Mar 9, 2022

/werft run

👍 started the job as gitpod-build-ak-jb-repo-plugins.11

@akosyakov akosyakov force-pushed the ak/jb_repo_plugins branch 2 times, most recently from 2fa2b23 to 27ac4ba Compare March 9, 2022 12:01
@akosyakov
Copy link
Member Author

I tried with EAP. It is possible to install plugins, but some plugins can freeze the backend startup, so we need a strategy to troubleshoot if we are going forward with it.

@akosyakov
Copy link
Member Author

akosyakov commented Mar 10, 2022

/werft run

👍 started the job as gitpod-build-ak-jb-repo-plugins.15

@akosyakov akosyakov force-pushed the ak/jb_repo_plugins branch 4 times, most recently from b390ab1 to 08f2329 Compare March 10, 2022 13:48
@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 28, 2022
@akosyakov
Copy link
Member Author

akosyakov commented Apr 1, 2022

/werft run

👍 started the job as gitpod-build-ak-jb-repo-plugins.44

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 1, 2022
@akosyakov akosyakov force-pushed the ak/jb_repo_plugins branch 2 times, most recently from 82ca477 to e871c0b Compare April 4, 2022 08:45
@felladrin
Copy link
Contributor

/werft run with-clean-slate-deployment=true

@felladrin felladrin force-pushed the ak/jb_repo_plugins branch from e871c0b to 6ebe4a9 Compare April 6, 2022 16:46
@felladrin felladrin marked this pull request as ready for review April 6, 2022 17:24
@felladrin felladrin requested review from a team April 6, 2022 17:24
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Apr 6, 2022
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clear and the tests ran accordingly to the description.

✅ Test Case 1: Plugin is not available on Stable Backend IDE.

Screenshot 2022-04-06 at 14 14 30

Screenshot 2022-04-06 at 14 43 49

✅ Test Case 2: Plugin is available on EAP Backend IDE.

Screenshot 2022-04-06 at 14 19 48

Screenshot 2022-04-06 at 14 43 59

See .gitpod.yml from the target repo. It contains the plugin saw in the screenshot above:

jetbrains:
  plugins:
    - com.haulmont.jpab

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebApp changes look good!

small and kind nudge: the smaller the PR, and number of teams involved, the easier the review - and quicker the approval. 🧘

@roboquat roboquat merged commit 584f8d9 into main Apr 7, 2022
@roboquat roboquat deleted the ak/jb_repo_plugins branch April 7, 2022 13:25
@roboquat roboquat added the deployed: IDE IDE change is running in production label Apr 7, 2022
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production editor: jetbrains release-note size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to define Jetbrains plugins to be installed on a given project
6 participants