Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix jetbrains auto update error #9216

Merged
merged 1 commit into from
Apr 11, 2022
Merged

[ci] fix jetbrains auto update error #9216

merged 1 commit into from
Apr 11, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Apr 11, 2022

Description

[ci] fix jetbrains auto update error
the version of base image golang is too low version (1.6), which causes compilation error on this job

it's broken job since #8630 merged because it add dependency of status

https://github.com/gitpod-io/gitpod/pull/8630/files#diff-4defccbad55f23ea3f1d8a743f62a8d6fe01adaf9daf183b82190b8f2ddcb034R11-R14

Related Issue(s)

Fixes #

How to test

Go to https://github.com/gitpod-io/gitpod/actions/workflows/jetbrains-auto-update.yml
start a Github Action, use branch pd/fix-jb-job, it should work

or see this job https://github.com/gitpod-io/gitpod/runs/5969072238?check_suite_focus=true

Release Notes

NONE

Documentation

@iQQBot iQQBot marked this pull request as draft April 11, 2022 08:49
@iQQBot iQQBot marked this pull request as ready for review April 11, 2022 09:00
@felladrin
Copy link
Contributor

Glad you found the solution, @iQQBot!

Could you add to the PR description why the fixed version of Golang was needed?
Is it upgrading or downgrading the version, compared to the Go version from the base image?

@mustard-mh mustard-mh self-requested a review April 11, 2022 10:27
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roboquat roboquat merged commit af46e9d into main Apr 11, 2022
@roboquat roboquat deleted the pd/fix-jb-job branch April 11, 2022 10:28
@mustard-mh
Copy link
Contributor

imag

@felladrin I think it's Go version too old, you can see logs in job detail https://github.com/gitpod-io/gitpod/runs/5960755125?check_suite_focus=true

@iQQBot
Copy link
Contributor Author

iQQBot commented Apr 11, 2022

Thanks @mustard-mh for clarifying, that's the truth

the version of base image golang is too low version (1.6), which causes compilation error on this job
it's broken job since #8630 merged because it add dependency of status
https://github.com/gitpod-io/gitpod/pull/8630/files#diff-4defccbad55f23ea3f1d8a743f62a8d6fe01adaf9daf183b82190b8f2ddcb034R11-R14

CC: @mustard-mh @felladrin

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants