-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly update response in openvsx proxy #9113
Conversation
676c6c4
to
d979e61
Compare
604554f
to
1da7988
Compare
1da7988
to
fcd932c
Compare
fcd932c
to
01cc150
Compare
@jeanp413 |
Sorry for the noise, after testing it does behave as I described. I was confused by mentioning of openvsxorg.blob.core.windows.net. |
@iQQBot @mustard-mh the changes seem to do the job, it would be good if you could review go code |
01cc150
to
b0a52a0
Compare
b0a52a0
to
ffce158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go code looks good
/hold
Only in the original code there are a lot of conversions between []byte and string, some of which are not necessary, bytes have almost the same methods as strings, as well as Count, Replace, etc., but these are not included in this PR
feel free to unblock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also works well for me.
/unhold |
Description
Updates response when it's compressed
Related Issue(s)
Fixes #
How to test
NODE_DEBUG=http,https,tls /ide/node /ide/out/server-main.js --install-extension znck.vue --do-not-sync --log trace 2> debug.log
in terminaldebug.log
file that only requests to the openvsx proxy are made and extensions are installed sucessfullyRelease Notes