[public-api] Proxy GetWorkspace to server #9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
easyCZ
force-pushed
the
mp/papi-get-ws-server
branch
from
cdb6da1 to
1e1c229
Compare
easyCZ
force-pushed
the
mp/papi-extract-bearer-token
branch
from
3796657 to
ab3492a
Compare
easyCZ
force-pushed
the
mp/papi-get-ws-server
branch
from
4ff236b to
74a689a
Compare
easyCZ
force-pushed
the
mp/papi-get-ws-server
branch
from
cc46f55 to
e434967
Compare
easyCZ
force-pushed
the
mp/papi-get-ws-server
branch
from
85d862a to
fa58955
Compare
easyCZ
force-pushed
the
mp/papi-get-ws-server
branch
from
fa58955 to
d38c40a
Compare
easyCZ
force-pushed
the
mp/papi-get-ws-server
branch
from
d38c40a to
1dd8f28
Compare
easyCZ
changed the title
|
Walked through the code with @easyCZ and tested. LGTM |
laushinka
approved these changes
May 4, 2022
|
/unhold |
roboquat
added
deployed: webapp
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetWorkspaceproxies request to Server. It does so by establishing a web-socket connection for each request and forwards the request credentials along. This approach is rather inefficient as we require a full WS connection for a single RPC and we immediately tear down the connection but it's a working baseline on which we can improve. It's a 🛹 .Related Issue(s)
How to test
Release Notes
Documentation
NONE
/uncc
/hold