Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[public-api] Convert to a cobra command and add config #9720

Merged
merged 2 commits into from
May 4, 2022
Merged

[public-api] Convert to a cobra command and add config #9720

merged 2 commits into from
May 4, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 3, 2022 •
edited
Loading

Description

Makes public-api-server entrypoint a cobra-command to allow us to:

  • Easily specify flags
  • Parse flags
  • Decouple invocation of start from definition of the server

Also specifies the GitpodAPI URL as a config value which is needed for #9704

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

/uncc
/hold

@easyCZ easyCZ changed the title [public-api] Restructure packages to better align with other components [public-api] Convert to a cobra command and add config May 3, 2022
@easyCZ easyCZ changed the base branch from main to mp/papi-restructure May 3, 2022 12:18
Base automatically changed from mp/papi-restructure to main May 3, 2022 14:25
@easyCZ easyCZ force-pushed the mp/papi-config branch from eeec954 to 4a038c1 Compare May 3, 2022 18:58
@easyCZ easyCZ force-pushed the mp/papi-config branch from 4a038c1 to 1591a1a Compare May 3, 2022 19:02
@easyCZ easyCZ marked this pull request as ready for review May 3, 2022 19:02
@easyCZ easyCZ requested a review from a team May 3, 2022 19:02
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 3, 2022
This was referenced May 3, 2022
Merged
Merged
@laushinka
Copy link
Contributor

Works as advertised!

@easyCZ easyCZ force-pushed the mp/papi-config branch from 1591a1a to 1367bc5 Compare May 4, 2022 09:21
@easyCZ
Copy link
Member Author

easyCZ commented May 4, 2022

/unhold

@roboquat roboquat merged commit ca76283 into main May 4, 2022
@roboquat roboquat deleted the mp/papi-config branch May 4, 2022 09:27
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @laushinka @roboquat