Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a collection of a few smaller changes that should improve the DevX of using our dev/preview scripts:
./dev/preview/*.sh
are all scripts that are intended to be run by the user. All other scripts are moved to util and test - this makes it easier as a developer to get an overview of what "commands" are available (we really should create a go-based CLI soon)./dev/preview/*.sh
arecwd
agnostic.VM_NAME=mads-impro9290016879 ../dev/preview/ssh-vm.sh
- it will still default to the VM of the branch if you don't explicitly setVM_NAME
. Using this consistently means that it's easy to access a VM that's based off another branch than the one you're on (e.g. if you want to test something on the preview environment ofmain
).kubectx
name so it's possible to have multiple contexts installed in a workspace. This is useful for people (like me) who might use a single workspace to work on a lot of different branches.dev/preview/list-vms.sh
script so it's easier to find the names of VM for when you want to useVM_NAME
. E.g.dev/preview/list-vms.sh | grep mads
and thenVM_NAME=xyz ../dev/preview/ssh-vm.sh
Related Issue(s)
Fixes #9713
How to test
I tested all scripts in four different ways
Release Notes
Documentation
N/A