Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Go to 1.20.6 #1041

Merged
merged 9 commits into from
Jul 12, 2023
Merged

update Go to 1.20.6 #1041

merged 9 commits into from
Jul 12, 2023

Conversation

0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Feb 16, 2023

Description

Update Go to version 1.20.2

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

@0xmohit 0xmohit requested a review from a team February 16, 2023 12:11
@gitpod-io
Copy link

gitpod-io bot commented Feb 16, 2023

@kylos101
Copy link
Collaborator

kylos101 commented Mar 3, 2023

👋 @atduarte @loujaybee , for your 👀 , I'm not sure when you'll be considering the next changelog, but this is certainly a candidate to give users a heads up about.

@Siddhant-K-code
Copy link
Member

Will followup on this, after release of #1017

@0xmohit 0xmohit changed the title update Go to 1.20.1 update Go to 1.20.2 Mar 9, 2023
@RicePatrick
Copy link

Hey @Siddhant-K-code - any update on this one? We use gitpod on an open source project that uses go 1.20, and it's really obnoxious right now to tell our contributors to manually install it. We could add a task that installs it, but we'd rather just use the workspace image.

@axonasif
Copy link
Member

axonasif commented Mar 28, 2023

but we'd rather just use the workspace image.

👋 @PatrickRice-KSC, you can do exactly that through a custom workspace image until we update the go version in here. Please see:

You can change the FROM gitpod/workspace-base:latest line to FROM gitpod/workspace-base:2023-03-24-22-45-37 and ENV GO_VERSION=1.17 to ENV GO_VERSION=1.20.2 from the guide above for latest ubuntu jammy and go versions.


You may also want to check the source code of workspace-go image dockerfile for reference:

@kylos101 kylos101 requested a review from a team April 17, 2023 20:04
@kylos101
Copy link
Collaborator

@loujaybee @laushinka is this something IDE team can consider for the future?

Comment on lines 5 to 7
- name: "1.20.2"
args:
GO_VERSION: 1.20
GO_VERSION: 1.20.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent stable version is 1.20.3 now. (reference)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.20.4 now

@kylos101
Copy link
Collaborator

@loujaybee @laushinka is this something IDE team can consider for the future?

@loujaybee this is a good example of something where we'd want to give folks a heads up in the changelog. For example, share when it is expected to land and be latest, and what tags folks should pin to (to use an old version, if they cannot use the latest).

@iQQBot
Copy link
Contributor

iQQBot commented May 22, 2023

@kylos101 Can you briefly explain what is stopping us from upgrading the version, I checked the release note and didn't find any major breaking change, maybe I missed something.

@kylos101
Copy link
Collaborator

@kylos101 Can you briefly explain what is stopping us from upgrading the version, I checked the release note and didn't find any major breaking change, maybe I missed something.

Hey @iQQBot , prior to landing, I suggested you share in the changelog that this change is coming. Why? After upgrading from 1.18 to 1.19, with the Gitpod mono repo, we saw that golangci-lint had new failures that we did not see previously. Those had to be unexpectedly fixed. Some customers might prefer to insulate themselves from this change, and continue using 1.19, until they are ready to absorb 1.20. They would do this, by using a time stamped image, instead of latest. This goes back to socializing release channels with @loujaybee.

@kylos101
Copy link
Collaborator

@iQQBot 👋 , for example, if we merge this today, it would be good to share a related changelog entry, so that next week, when this lands as latest, folks understand their options. Let me know if you need anything else?

@gengjiawen
Copy link
Contributor

@iQQBot 👋 , for example, if we merge this today, it would be good to share a related changelog entry, so that next week, when this lands as latest, folks understand their options. Let me know if you need anything else?

put this in https://github.com/gitpod-io/workspace-images/blob/main/CHANGELOG.md ?

@kylos101
Copy link
Collaborator

kylos101 commented May 23, 2023

@iQQBot wave , for example, if we merge this today, it would be good to share a related changelog entry, so that next week, when this lands as latest, folks understand their options. Let me know if you need anything else?

put this in https://github.com/gitpod-io/workspace-images/blob/main/CHANGELOG.md ?

@loujaybee @iQQBot @filiptronicek @laushinka I'd recommend a changelog entry on the website. The users are options now are to do nothing (use latest), use the present tag that is latest now (to avoid the change), or use the tag associated with this to test the change, before it is usable as latest. Similar to this entry. Why the recommendation? Because we don't currently provide an easy means for customers to adopt different channels of updates (one that changes fast versus slow).

@gengjiawen
Copy link
Contributor

I'd recommend a changelog entry on the website.

tbh this will bring to much extra work for contributor, maybe put on CHANGELOG.md first, send weekly update to website by maintainer.

@filiptronicek filiptronicek changed the title update Go to 1.20.2 update Go to 1.20.5 Jun 12, 2023
@akosyakov
Copy link
Member

I wonder why don't have the following process:

  • release latest once a month
  • nightly publish next for people to try and provide feedback
  • merge PRs without being afraid because of above, stop merging a week or so before latest release

Run it all automatically as we do with VS Code, JetBrains, let the community help catch issues.

Copy link
Collaborator

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filiptronicek @iQQBot I like the suggestion from @gengjiawen , about using the changelog.md file in this repo to share related chnages, it reduces friction. Approving for now, to unblock.

@filiptronicek
Copy link
Member

Tested independently in a workspace

@filiptronicek filiptronicek changed the title update Go to 1.20.5 update Go to 1.20.6 Jul 12, 2023
@filiptronicek filiptronicek merged commit 507b24f into gitpod-io:main Jul 12, 2023
2 checks passed
args:
GO_VERSION: 1.19.11
- name: "1.20.6"
- name: "1.20"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, @filiptronicek !! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants