-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Go to 1.20.6
#1041
update Go to 1.20.6
#1041
Conversation
👋 @atduarte @loujaybee , for your 👀 , I'm not sure when you'll be considering the next changelog, but this is certainly a candidate to give users a heads up about. |
Will followup on this, after release of #1017 |
Hey @Siddhant-K-code - any update on this one? We use gitpod on an open source project that uses go 1.20, and it's really obnoxious right now to tell our contributors to manually install it. We could add a |
👋 @PatrickRice-KSC, you can do exactly that through a custom workspace image until we update the go version in here. Please see: You can change the You may also want to check the source code of |
@loujaybee @laushinka is this something IDE team can consider for the future? |
chunks/lang-go/chunk.yaml
Outdated
- name: "1.20.2" | ||
args: | ||
GO_VERSION: 1.20 | ||
GO_VERSION: 1.20.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recent stable version is 1.20.3
now. (reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.20.4 now
@loujaybee this is a good example of something where we'd want to give folks a heads up in the changelog. For example, share when it is expected to land and be latest, and what tags folks should pin to (to use an old version, if they cannot use the latest). |
@kylos101 Can you briefly explain what is stopping us from upgrading the version, I checked the release note and didn't find any major breaking change, maybe I missed something. |
Hey @iQQBot , prior to landing, I suggested you share in the changelog that this change is coming. Why? After upgrading from 1.18 to 1.19, with the Gitpod mono repo, we saw that golangci-lint had new failures that we did not see previously. Those had to be unexpectedly fixed. Some customers might prefer to insulate themselves from this change, and continue using 1.19, until they are ready to absorb 1.20. They would do this, by using a time stamped image, instead of |
@iQQBot 👋 , for example, if we merge this today, it would be good to share a related changelog entry, so that next week, when this lands as latest, folks understand their options. Let me know if you need anything else? |
put this in https://github.com/gitpod-io/workspace-images/blob/main/CHANGELOG.md ? |
@loujaybee @iQQBot @filiptronicek @laushinka I'd recommend a changelog entry on the website. The users are options now are to do nothing (use latest), use the present tag that is latest now (to avoid the change), or use the tag associated with this to test the change, before it is usable as latest. Similar to this entry. Why the recommendation? Because we don't currently provide an easy means for customers to adopt different channels of updates (one that changes fast versus slow). |
tbh this will bring to much extra work for contributor, maybe put on |
I wonder why don't have the following process:
Run it all automatically as we do with VS Code, JetBrains, let the community help catch issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filiptronicek @iQQBot I like the suggestion from @gengjiawen , about using the changelog.md file in this repo to share related chnages, it reduces friction. Approving for now, to unblock.
Tested independently in a workspace |
args: | ||
GO_VERSION: 1.19.11 | ||
- name: "1.20.6" | ||
- name: "1.20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, @filiptronicek !! 🎉
Description
Update Go to version 1.20.2
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation