Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump Rust to 1.70.0 #1094

Merged
merged 4 commits into from
Jul 13, 2023
Merged

feat: Bump Rust to 1.70.0 #1094

merged 4 commits into from
Jul 13, 2023

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code requested a review from a team May 16, 2023 03:09
@gitpod-io
Copy link

gitpod-io bot commented May 16, 2023

@filiptronicek
Copy link
Member

Just curious trying to accustom myself with how workspace-images are done: @Siddhant-K-code how do you personally test changes for images? Or do just let the tests handle everything?

@gengjiawen gengjiawen mentioned this pull request May 23, 2023
Closed
filiptronicek
filiptronicek approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1099 (review)

@filiptronicek
Copy link
Member

I suppose #1041 (comment) also applies here

@Siddhant-K-code
Copy link
Member Author

Any Timeline to proceed with this? Because, we also have 1.70.0 now: https://github.com/gitpod-io/website/pull/3729

@filiptronicek
Copy link
Member

https://github.com/gitpod-io/website/pull/3733 for the changelog.

@filiptronicek
Copy link
Member

@Siddhant-K-code do we need to re-trigger the build again to get 1.70? If so, could you please push that change so that we can merge this (and sorry for the delay 🙏)

@Siddhant-K-code
Copy link
Member Author

@Siddhant-K-code do we need to re-trigger the build again to get 1.70?

I don't think so. I've updated the branch which would re-trigger GH Actions. (This should work)

@Siddhant-K-code Siddhant-K-code changed the title feat: Bump Rust to 1.69.0 feat: Bump Rust to 1.70.0 Jun 12, 2023
@Siddhant-K-code
Copy link
Member Author

Something is looking off 🤔. We need to confirm the Rust version 🫠

image

@filiptronicek
Copy link
Member

@Siddhant-K-code can you try bumping TRIGGER_REBUILD again? Maybe that way we don't have to compete for the cache key.

@filiptronicek
bump again
3d2c591 
Let's... try 🤷
@Siddhant-K-code
Copy link
Member Author

3d2c591, still not working 🫠

@kylos101
Copy link
Collaborator

Related Re: the PR action failing/blocking merge

@kylos101 kylos101 merged commit c78b8ee into main Jul 13, 2023
2 checks passed
@filiptronicek filiptronicek deleted the bump/rust branch July 13, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Siddhant-K-code @filiptronicek @kylos101 @gengjiawen