Skip to content

BF: remove ddt from requirements.txt since no ddt required at run time. #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

yarikoptic
Copy link
Contributor

Otherwise, since requirements.txt is loaded into install_requires, any installation
which manages to miss installing ddt could cause setuptools to freak out.
E.g.

here is a traceback from running tests of datalad

======================================================================
ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata
    extractor_cls = extractors[mtype_key].load()
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load
    self.require(*args, **kwargs)
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)
  File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython

in conda environment. Original commit 74a0507
which added ddt there unfortunately does not state the reason so probably was
just a slip

Otherwise, since requirements.txt is loaded into install_requires, any installation
which manages to miss installing ddt could cause setuptools to freak out.
E.g.

here is a traceback from running tests of datalad

    ======================================================================
    ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata
        extractor_cls = extractors[mtype_key].load()
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load
        self.require(*args, **kwargs)
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require
        items = working_set.resolve(reqs, env, installer, extras=self.extras)
      File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
        raise DistributionNotFound(req, requirers)
    pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython

in conda environment.  Original commit 74a0507
which added ddt there unfortunately does not state the reason so probably was
just a slip
@Byron
Copy link
Member

Byron commented Aug 21, 2019

Thanks a lot! Should I cut a release?

@yarikoptic
Copy link
Contributor Author

yarikoptic commented Aug 22, 2019

If not too much trouble - it would be great! Thanks in advance!

@Byron
Copy link
Member

Byron commented Aug 22, 2019

Done, see v3.0.2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants