balanced_customer_href is corrupted

[chadwhitacre]

https://www.gittip.com/autogato/ has a bad link to Balanced.
https://www.gittip.com/matt-lowe/ has a good link (so the problem isn't universal).

Discovered during #2084. Is this a regression from #1369? Or from #2056? Or ... ?

If the balanced_customer_href is bad then we're going to have API failures during payday. And that's bad. Three stars!

[chadwhitacre]

This is a regression from #2036. Not only did the name of the field change, the format of the value changed as well. Old:

/v1/marketplaces/MARKETPLACE_ID/accounts/ACCOUNT_ID

New:

/customers/CUSTOMER_ID

[chadwhitacre]

Here's how we compute the URL to show on the profile page:

https://dashboard.balancedpayments.com/#/{{ participant.balanced_customer_href[4:] }}

[chadwhitacre]

URLs like this:

https://dashboard.balancedpayments.com/#/v1/marketplaces/MARKETPLACE_ID/accounts/ACCOUNT_ID

now redirect to URLs like:

https://dashboard.balancedpayments.com/#/v1/marketplaces/MARKETPLACE_ID/customers/CUSTOMER_ID

[chadwhitacre]

URLs like this:

https://dashboard.balancedpayments.com/#/customer/CUSTOMER_ID

redirect to:

https://dashboard.balancedpayments.com/#/marketplaces

with an error message, "Invalid URL specified, please check the URL.":

[chadwhitacre]

cc: @matthewfl

[chadwhitacre]

We have a BalancedThing class, but we don't use that during payday. Instead, we call balanced.Customer.fetch directly. Given that payday didn't completely fail last week, I surmise that fetch can take either form, the old account_uri and the new customer_href forms. So ... we should be good for payday (#2084) and this is just a cosmetic bug. Demoting to ★★☆ and proceeding with #2084.

[chadwhitacre]

Old ACCOUNT_IDs count for new CUSTOMER_IDs, so we should be able to fix this by modifying the values in balanced_customer_href. We'd also need to start storing MARKETPLACE_ID somewhere else, probably in an envvar. And then we'd need to update the link itself.

[matthewfl]

@whit537 you are correct that the fetch method can take the old (/v1/marketplace/MPadsf/account/asdf) url or the new (/customers/asdf) href. However, the api will always return the link on the object using the new href.
If you want, you could upgrade the href in the database by having a script preform a get request against the balanced api and the saving the new href.

for the dashboard links I am not 100 sure what needs to happen to make that work, I suppose you could prefix that with /marketplace/mpasdf/ to make it work.

Hopefully this answers any questions you have about corrupt hrefs, otherwise I am not sure what you mean

[chadwhitacre]

MARKETPLACE_ID is already stored somewhere under balanced. Grep around.

[seanlinsley]

Looks like @cczona is being bit by this: https://twitter.com/cczona/status/478714841209651201

[cczona]

Any news on this? I've got a backlog of several weeks tips that weren't transferred. If possible, I'd like to get those transferred tomorrow with this week's scheduled one.

[cczona]

Ping. Both of my accounts (cczona & callbackwomen) still have not made any external transfers since May 15th. The former has its banking info intact, so I'm not sure why it's not transferring. The latter's banking info was restored a week ago, prior to the scheduled transfer date, but the transfer again didn't happen.

[clone1018]

@cczona Just so you know, banking information is on the "Account" tab not the "Profile" tab.

Context: https://twitter.com/cczona/status/478714841209651201

[clone1018]

Oh I see @duckinator said that already, nevermind.

[chadwhitacre]

@cczona Sorry this has languished. Let's figure this out ...

[chadwhitacre]

First step is to understand whether @cczona is indeed getting bitten by this issue, or something else.

[chadwhitacre]

(If something else, let's move to a different ticket.)

[cczona]

Sure thing. What do you need from me?

[chadwhitacre]

@cczona I'm reloading this ticket into my brain. The link from your Gittip profile to your account page in the Balanced dashboard does exhibit the behavior reported above, so it sounds like we're in the right place.

It's possible that we may need to repair your balance in Gittip if we thought we were making deposits when we weren't, need to answer that.

Also need to understand what the root issue is and how to fix it, and whether we should fix the root cause here or take care of your situation as a one-off ...

[chadwhitacre]

Your balanced_customer_href does not match the format above, even though it still gives the "Invalid URL" message. So still maybe a different issue ... ?

[cczona]

Do I have control over balanced_customer_href?

[chadwhitacre]

@cczona Kinda maybe probably? Researching ...

[chadwhitacre]

I've found @cczona's account by searching the Balanced dashboard. There is no bank account on file there right now. So there's two issues here:

• The link between @cczona's Gittip and Balanced accounts is broken.
• There is no longer a bank account on file at Balanced.

[chadwhitacre]

@cczona Probably the quickest way out of this for you would be to re-enter your bank account details on Gittip (have you tried that yet?). Then we can either do a manual payout right now or just let it run tomorrow.

That way you aren't blocking while we resolve whatever the root causes are here.

[chadwhitacre]

@cczona Though we do need to ensure that we haven't corrupted your Gittip balance before we do the payout.

[chadwhitacre]

There is no bank account on file there right now.

But I do see many successful payouts up through May.

[chadwhitacre]

#1811 is the issue for balance corruption due to not properly handling failed bank payouts.

[chadwhitacre]

Picking up w/ @cczona's case over on #1811 ...

[Changaco]

Tagging as "Ready to Start", we have 2953 users affected by this (select count(*) from participants where balanced_customer_href not like '/customers/%';).

[Changaco]

Done in #3286.