Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better wsl support #1199

Merged
merged 1 commit into from
Oct 1, 2021
Merged

better wsl support #1199

merged 1 commit into from
Oct 1, 2021

Conversation

glacambre
Copy link
Owner

@glacambre glacambre commented Oct 1, 2021 •
edited
Loading

Closes #1198.

@glacambre glacambre force-pushed the better_wsl_support branch 4 times, most recently from a42bc8b to 3aa910c Compare October 1, 2021 05:35
@glacambre
Better handling of wsl nastyness
58bbb59 
#1198 reports that cmd.exe
and powershell.exe might not be available in the WSL path. Try to use
absolute paths if relative ones do not work and provide better error
messages when this doesn't work.
@glacambre glacambre merged commit 35ddc81 into master Oct 1, 2021
@glacambre glacambre deleted the better_wsl_support branch October 1, 2021 05:55
xudyang1 added a commit to xudyang1/firenvim that referenced this pull request Jul 27, 2024
@xudyang1
fix: use noninteractive powershell
4825d00 
This PR is a continuation of glacambre#1199 and glacambre#1577. glacambre#1199 adds support for
running `powershell.exe` when it's not in the path (this occurs when
WSL user sets `appendWindowsPath=false` in `/etc/wsl.conf`). glacambre#1577 adds
`-NonInteractive` option to `powershell.exe` commands.
@xudyang1 xudyang1 mentioned this pull request Jul 27, 2024
Merged
glacambre pushed a commit that referenced this pull request Jul 29, 2024
@xudyang1 @glacambre
fix: use noninteractive powershell
c5ea28f 
This PR is a continuation of #1199 and #1577. #1199 adds support for
running `powershell.exe` when it's not in the path (this occurs when
WSL user sets `appendWindowsPath=false` in `/etc/wsl.conf`). #1577 adds
`-NonInteractive` option to `powershell.exe` commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to install firenvm / Neovim died without answering
1 participant
@glacambre