fix: run scripts in noninteractive shell (#1547) #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firenvim on Windows relys on powershell scripts to run registry keys installation and uninstallation. Here are the codes: https://github.com/glacambre/firenvim/blob/8c6c00aae7e5762cbcb4cd0df5848e959c4a9572/autoload/firenvim.vim#L890 https://github.com/glacambre/firenvim/blob/8c6c00aae7e5762cbcb4cd0df5848e959c4a9572/autoload/firenvim.vim#L958 During debugging, I add `echo o` right after calling the `system` function, the output shows error ```text Cannot load PSReadline module. Console is running without PSReadline. ``` But weirdly, `v:shell_error` is still `0`. `PSReadline` is a module usually installed for interactive prompt usage. `Powershell.exe` provides option `-NonInterative` for running automated scripts in non-interactive shell. Adding the `-NonInteractive` option fixes glacambre#1547 as the scripts run successfully without error. > [!NOTE] > This pull request only fixes firenvim installation on Windows host and WSL2 environment. Uninstallation scripts run successfully when running nvim on the host (`%LOCALAPPDATA/firenvim/*` files and corresponding registry keys are removed); run `firenvim#uninstall()` on WSL side only removes the binary in WSL (`stdpath('data')/firenvim` in WSL or `$HOME/.local/share/firenvim/firenvim`) > > A separate issue glacambre#1576 tracks the uninstallation bug on WSL side
|
Wow, great debugging skills, thank you for taking the time to open a PR! :) |
xudyang1
added a commit
to xudyang1/firenvim
that referenced
this pull request
Jul 27, 2024
This PR is a continuation of glacambre#1199 and glacambre#1577. glacambre#1199 adds support for running `powershell.exe` when it's not in the path (this occurs when WSL user sets `appendWindowsPath=false` in `/etc/wsl.conf`). glacambre#1577 adds `-NonInteractive` option to `powershell.exe` commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firenvim on Windows relys on powershell scripts to run registry keys installation and uninstallation. Here are the codes:
firenvim/autoload/firenvim.vim
Line 890 in 8c6c00a
firenvim/autoload/firenvim.vim
Line 958 in 8c6c00a
During debugging, I add
echo oright after calling thesystemfunction, which then shows errorBut weirdly,
v:shell_erroris still0.PSReadlineis a module usually installed for interactive prompt usage.Powershell.exeprovides option-NonInterativefor running automated scripts in non-interactive shell. Adding the-NonInteractiveoption fixes #1547 as the scripts run successfully without error.Note
This pull request only fixes firenvim installation on Windows host and
WSL2 environment. Uninstallation scripts run successfully when running firenvim on the host (
%LOCALAPPDATA/firenvim/*files and corresponding registry keys are removed); runfirenvim#uninstall()on WSL side only removes the binary in WSL(
stdpath('data')/firenvimin WSL or$HOME/.local/share/firenvim/firenvim)A separate issue #1576 tracks the uninstallation bug on WSL side