Deprecate yielder.concat #4
Closed
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephTLyons
force-pushed
the
deprecate-yielder.concat
branch
from
1df91cb to
7a9a66e
Compare
Closed
lpil
reviewed
Dec 16, 2024
|
Oh huh, that's strange, I actually misread the source code when looking at it. I guess my dyslexia is in full effect right now. Apologies for the time wasted on PRs that haven't made sense - super obvious now. |
|
I should really find some time to document these conventions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yielderseems to mostly follow the interface oflist. We deprecatedlist.concactin favor oflist.flatten, in Gleam's spirit of only having one way to do things. Feels like we should do the same thing here.Reference:
list.flattenorlist.concatstdlib#707list.concatstdlib#710