Deprecate yielder.prepend #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephTLyons
force-pushed
the
deprecate-yielder.prepend
branch
from
27d6980 to
6210b92
Compare
|
The current design matches the list module, and I don't think we want to have the same function twice with different names, so I think the current implementation is best to stay. |
|
Oh you're right! Maybe that's where I pulled the original PR suggestion from. Whoops! Nothing to see here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we might've made a mistake with #1, as we now have
yielder.prependandyielder.append, butyielder.prependtakes in a single element andyielder.prepend .appendtakes in anotheryielderof elements. Seems like those functions should have the same inputs, and it is confusing that they don't. My proposal is to rename this toyielder.push_front, to match the same nomenclature used in other gleam libs, such asdeque, to avoid confusion.https://hexdocs.pm/gleam_deque/gleam/deque.html#push_front
(I wouldn't normally open a PR without talking about it first, but this one and #4 are so small that I'm ok with them being throwaways if not wanted).