Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Some DataTables markup issues #653

Closed
4 tasks done
sergeyklay opened this issue Dec 19, 2013 · 15 comments
Closed
4 tasks done

Some DataTables markup issues #653

sergeyklay opened this issue Dec 19, 2013 · 15 comments

Comments

@sergeyklay
Copy link
Contributor

Please see at screenshot

  • Apply button - doesn't resemble a button, at least initially
  • Search field is broken
  • Field for Show xxx entries must be longer
  • Archive label background merges with <tr> background

In Mozilla Firefox 26.0 this page looks like as on screenshot

2013-12-19_1051x559_scrot

@sergeyklay
Copy link
Contributor Author

P.S. Search input field have control-label class

@sandeepone
Copy link
Member

Will fix these things. Should i remove the control-label or add control-label class.

@sandeepone
Copy link
Member

I think it should be form-control am i right?? I forgot BS now.. my head is pumping :)

@sergeyklay
Copy link
Contributor Author

Yep, form-control :)

@sergeyklay
Copy link
Contributor Author

For search input field:
need replace
class="control-label col-xs-4 col-md-3 col-sm-3"
to
class="form-control input-sm"

With these changes:
2013-12-20_1159x211_scrot

@sergeyklay
Copy link
Contributor Author

For example I tried a slightly different markup and received what you see in the second screenshot:

Current markup:
2013-12-20_1035x60_scrot

Tested markup:
2013-12-20_1163x46_scrot

@sergeyklay
Copy link
Contributor Author

Mobile viewport issue
2013-12-20_344x240_scrot

@sergeyklay
Copy link
Contributor Author

This code is not perfect, but it demonstrates that the markup can be more responsive:

<fieldset class="bulk-actions form-actions rounded">
    <div class="row">
        <div class="form-group col-xs-8 col-sm-3 col-md-2">
            <div class="control-group">
                <?php echo Form::select('...', array(), '', array('class' => 'form-control input-sm')); ?>
            </div>
        </div>
        <div class="form-group col-xs-4 col-sm-2 col-md-2">
            <?php echo Form::submit('...', __('Apply'), array('class'=>'btn btn-primary btn-sm')); ?>
        </div>
        <div class="form-group col-xs-6 col-sm-7 col-md-8 form-actions-right">
            <?php echo HTML::anchor('...', '<i class="fa fa-plus fa-white"></i> '.__('Compose'), array('class'=>'btn btn-success btn-sm')); ?>
        </div>
    </div>
</fieldset>

320x480
2013-12-20_305x111_scrot

768x1024
2013-12-20_748x49_scrot

1280x600
2013-12-20_1167x50_scrot

P.S. I used in example .form-actions-right class:

.form-actions-right {
    text-align: right;
}

@media only screen and (max-width: 767px) {
    .form-actions-right {
        text-align: left;
    }
}

Current view:
2013-12-20_356x234_scrot

@sergeyklay
Copy link
Contributor Author

P.S. Why Bulk Options? Mb Bulk Actions ?

@sergeyklay
Copy link
Contributor Author

I would also like note that we have some issue with tabs in mobile viewport. See twbs/bootstrap#11954

@sandeepone
Copy link
Member

Any update on this issue. Any PR on apply button??

@sergeyklay
Copy link
Contributor Author

Not ready yet

@sergeyklay
Copy link
Contributor Author

What about buttons dropdown button here?
http://getbootstrap.com/components/#btn-dropdowns-single

@sergeyklay
Copy link
Contributor Author

Must be closed

@sergeyklay
Copy link
Contributor Author

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants