Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting blackhole mechanism only if enabled in the configuration #415

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mambelli
Copy link
Contributor

@mambelli mambelli commented Jun 13, 2024

Setting the blackhole mechanism only if enabled in the configuration

Before there was an error when the attributes were not set in the frontend/factory configuration.
The last error here was preventing the Startd from starting:

06/13/24 06:14:14 (pid:240950) eth0 enabled Wake-on: no (raw: 0x00)
06/13/24 06:14:14 (pid:240950) Using network interface eth0 for hibernation
06/13/24 06:14:14 (pid:240950) my_popenv: Failed to exec /var/lib/condor/execute/dir_226360/glide_gQGfYg/main/condor/libexec/condor_power_state, errno=2 (No such file or directory)
06/13/24 06:14:14 (pid:240950) Initially invoking hibernation plugin '/var/lib/condor/execute/dir_226360/glide_gQGfYg/main/condor/libexec/condor_power_state ad'
06/13/24 06:14:14 (pid:240950) Failed to run hibernation plugin '/var/lib/condor/execute/dir_226360/glide_gQGfYg/main/condor/libexec/condor_power_state ad'
06/13/24 06:14:14 (pid:240950) Detected hibernation states:
06/13/24 06:14:17 (pid:240950) VM universe will be tested to check if it is available
06/13/24 06:14:17 (pid:240950) ERROR "Syntax error in START expression: '((TRUE && (SiteWMS_WN_Draining =?= False)) && (ifThenElse(isUndefined((RecentJobBusyTimeAvg < (1.0/)) && (RecentJobBusyTimeCount >= )), False, (RecentJobBusyTimeAvg < (1.0/)) && (RecentJobBusyTimeCount >= )) =?= False)) && ((True) && (True) && (True) && (True)) && (((GLIDEIN_ToRetire =?= UNDEFINED) || (CurrentTime < GLIDEIN_ToRetire))) && (True)'" at line 587 in file /var/lib/condor/execute/slot1/dir_2508072/userdir/build-ba6TSX/BUILD/condor-10.6.0/src/condor_startd.V6/util.cpp

You can see how the missing attributes (shell variables in condor_startup.sh) are causing a malformed START expression.

@mambelli mambelli self-assigned this Jun 13, 2024
Copy link
Contributor

@namrathaurs namrathaurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed solution looks good, but I do have a few questions that I have added in this PR as comments

creation/web_base/condor_startup.sh Show resolved Hide resolved
creation/web_base/condor_startup.sh Outdated Show resolved Hide resolved
doc/factory/custom_vars.html Show resolved Hide resolved
creation/web_base/condor_startup.sh Show resolved Hide resolved
Copy link
Contributor

@namrathaurs namrathaurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ready to be merged!

@mambelli mambelli merged commit e4c0edf into glideinWMS:master Jun 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants