Preventing the use of blackhole detection only when not used #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrathaurs
changed the title
mambelli
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415.
Note: This is a patch fix for the prevention mechanism (PR #415) that was added to the blackhole detection mechanism in #331.
TLDR;
PR #415 introduced a bug which resulted in the prevention mechanism to be effective only when the blackhole detection feature was not enabled (via the frontend configuration). When blackhole detection was necessary (aka, enabled), the prevention mechanism still continued to determine that blackhole detection was not needed, when in actual it should be needed. Turns out this was caused as a result of using the wrong case of the variable name involved in the determination logic. Specifically, the variable name should have been
glidein_blackhole_rate(shell variable name in the context of condor_startup.sh) instead ofGLIDEIN_BLACKHOLE_RATE(which is a frontend knob and is read fromglidein_config).