[BUGFIX] Convert component names after symbol allocation #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you cross link the related ember issue for easier future archeology 😜 |
rwjblue
reviewed
Jan 12, 2021
Currently component names are converted via the `customizeComponentName` option prior to symbol allocation. This means that a component can end up conflicting with an existing local variable, even though they logically represent different things. This PR ensures that customization happens after symbol allocation, as a final step within the symbol table itself. This also means that the correct value is passed through the rest of the AST and transformations, so it cannot conflict with keywords as well as other language constructs.
pzuraq
force-pushed
the
bugfix-convert-component-names-after-symbol-allocation
branch
from
4e4371f
to
a6896a2
Compare
rwjblue
approved these changes
Jan 12, 2021
|
Still need to cross link the Ember issue in the description. |
rwjblue
deleted the
bugfix-convert-component-names-after-symbol-allocation
branch
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Jan 21, 2021
Updates glimmer-vm to include glimmerjs/glimmer-vm#1253.
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Jan 21, 2021
Updates glimmer-vm to include glimmerjs/glimmer-vm#1253.
rwjblue
added a commit
to emberjs/ember.js
that referenced
this pull request
Jan 22, 2021
Updates glimmer-vm to include glimmerjs/glimmer-vm#1253.
kategengler
pushed a commit
to emberjs/ember.js
that referenced
this pull request
Jan 25, 2021
Updates glimmer-vm to include glimmerjs/glimmer-vm#1253. (cherry picked from commit a1b70d1)
Closed
sly7-7
pushed a commit
to sly7-7/ember.js
that referenced
this pull request
Mar 10, 2021
Updates glimmer-vm to include glimmerjs/glimmer-vm#1253.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently component names are converted via the
customizeComponentNameoption prior to symbol allocation. This means that a component can end
up conflicting with an existing local variable, even though they
logically represent different things. This PR ensures that customization
happens after symbol allocation, as a final step within the symbol table
itself. This also means that the correct value is passed through the
rest of the AST and transformations, so it cannot conflict with keywords
as well as other language constructs.
Fixes: emberjs/ember.js#19334