Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Convert component names after symbol allocation #1253

Merged
merged 1 commit into from
Jan 12, 2021
Merged

[BUGFIX] Convert component names after symbol allocation #1253

merged 1 commit into from
Jan 12, 2021
+76 −22

Commits on Jan 12, 2021

  1. [BUGFIX] Convert component names after symbol allocation 

    Currently component names are converted via the `customizeComponentName`
option prior to symbol allocation. This means that a component can end
up conflicting with an existing local variable, even though they
logically represent different things. This PR ensures that customization
happens after symbol allocation, as a final step within the symbol table
itself. This also means that the correct value is passed through the
rest of the AST and transformations, so it cannot conflict with keywords
as well as other language constructs.
    Chris Garrett committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    a6896a2 View commit details
    Browse the repository at this point in the history