Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artisanal Production Builds By Chad #444

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Artisanal Production Builds By Chad #444

merged 1 commit into from
Mar 26, 2017

Conversation

chadhietala
Copy link
Member

So some how this has caused 54 test failures, where I think majority of them are serializing an object into the DOM. Unsure why that is since expect, assert, and unwrap were basically just pass throughs.
screen shot 2017-03-25 at 8 20 20 pm

GavinJoyce
GavinJoyce reviewed Mar 26, 2017
View reviewed changes
packages/@glimmer/runtime/lib/compiled/opcodes/dom.ts Outdated
@@ -417,7 +410,7 @@ export class DynamicAttribute implements Attribute {
patch(env: Environment) {
let { element, cache } = this;

let value = expect(cache, 'must patch after flush').revalidate();
let value = cache;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be let value = cache.revalidate();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👁

@GavinJoyce GavinJoyce mentioned this pull request Mar 26, 2017
Closed
@chadhietala chadhietala force-pushed the artisinal-code-stripping branch from 9c7f756 to 6d5b3b8 Compare March 26, 2017 16:00
@chadhietala
Copy link
Member Author

screen shot 2017-03-26 at 9 05 36 am

@tomdale tomdale merged commit 82a2ab8 into master Mar 26, 2017
@tomdale tomdale deleted the artisinal-code-stripping branch March 26, 2017 16:34
@GavinJoyce
Copy link
Contributor

@tomdale I'm getting the following error after a yarn upgrade:

File: src/ui/components/my-table/template.hbs
The Broccoli Plugin: [broccoli-persistent-filter:GlimmerTemplatePrecompiler] failed with:
TypeError: (0 , _util.expect) is not a function
    at TemplateVisitor.get (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/template-visitor.js:390:37)
    at TemplateVisitor.TextNode (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/template-visitor.js:331:25)
    at TemplateVisitor.visit (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/template-visitor.js:248:24)
    at TemplateVisitor.Program (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/template-visitor.js:281:18)
    at TemplateVisitor.visit (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/template-visitor.js:248:24)
    at Function.compile (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/template-compiler.js:55:25)
    at Object.precompile (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/compiler/dist/commonjs/es5/lib/compiler.js:49:60)
    at GlimmerTemplatePrecompiler.processString (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/application-pipeline/dist/broccoli/glimmer-template-precompiler.js:14:45)
    at /Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/broccoli-persistent-filter/lib/strategies/default.js:10:19
    at initializePromise (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/rsvp/dist/rsvp.js:589:5)

The broccoli plugin was instantiated at:
    at GlimmerTemplatePrecompiler.Plugin (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/broccoli-persistent-filter/node_modules/broccoli-plugin/index.js:7:31)
    at GlimmerTemplatePrecompiler.Filter [as constructor] (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/broccoli-persistent-filter/index.js:62:10)
    at GlimmerTemplatePrecompiler (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/application-pipeline/dist/broccoli/glimmer-template-precompiler.js:7:9)
    at GlimmerApp.compiledHandlebarsTree (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/application-pipeline/dist/broccoli/glimmer-app.js:184:16)
    at GlimmerApp.javascriptTree (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/application-pipeline/dist/broccoli/glimmer-app.js:157:45)
    at GlimmerApp.toTree (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/@glimmer/application-pipeline/dist/broccoli/glimmer-app.js:127:27)
    at module.exports (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/ember-cli-build.js:21:14)
    at Class.setupBroccoliBuilder (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/ember-cli/lib/models/builder.js:72:19)
    at Class.init (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/ember-cli/lib/models/builder.js:52:10)
    at Class.superWrapper [as init] (/Users/gavin/dev/opensource/glimmerbench/preact-glimmer/node_modules/core-object/lib/assign-properties.js:32:18)

@GavinJoyce
Copy link
Contributor

I've got @glimmer/compiler 0.23.0-alpha.7 but it seems to be missing Chad's changes:

screen shot 2017-03-26 at 09 54 28

screen shot 2017-03-26 at 09 53 33

@tomdale perhaps there is a bug in the release script or you need to git pull?

chadhietala added a commit that referenced this pull request Apr 6, 2017
@chadhietala
Revert "Merge pull request #444 from tildeio/artisinal-code-stripping"
76e67cd 
This reverts commit 82a2ab8, reversing
changes made to c56ef68.
chadhietala added a commit that referenced this pull request Apr 6, 2017
@chadhietala
Revert "Merge pull request #444 from tildeio/artisinal-code-stripping"
c820fca 
This reverts commit 82a2ab8, reversing
changes made to c56ef68.
chadhietala added a commit that referenced this pull request Apr 6, 2017
@chadhietala
Revert "Merge pull request #444 from tildeio/artisinal-code-stripping"
65e91d5 
This reverts commit 82a2ab8, reversing
changes made to c56ef68.
chadhietala added a commit that referenced this pull request Apr 6, 2017
@chadhietala
Revert "Merge pull request #444 from tildeio/artisinal-code-stripping"
d4f5c3a 
This reverts commit 82a2ab8, reversing
changes made to c56ef68.
chadhietala added a commit that referenced this pull request Apr 10, 2017
@chadhietala
Revert "Merge pull request #444 from tildeio/artisinal-code-stripping"
0868554 
This reverts commit 82a2ab8, reversing
changes made to c56ef68.
rwjblue added a commit that referenced this pull request Apr 18, 2017
@rwjblue
Merge pull request #456 from glimmerjs/automated-builds
eecdf90 
Revert "Merge pull request #444 from tildeio/artisinal-code-stripping"
@kbullaughey kbullaughey mentioned this pull request May 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GavinJoyce GavinJoyce GavinJoyce left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadhietala @GavinJoyce @tomdale