Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #444 from tildeio/artisinal-code-stripping" #456

Merged
merged 2 commits into from
Apr 18, 2017

Conversation

chadhietala
Copy link
Member

@chadhietala chadhietala commented Apr 6, 2017

This reverts commit 82a2ab8, reversing
changes made to c56ef68.

This also adds some automatic code stripping for places where I was removing things manually.

@chadhietala chadhietala force-pushed the automated-builds branch 3 times, most recently from 0d4ac38 to 1c6f1e7 Compare April 9, 2017 22:18
@rwjblue
Copy link
Member

rwjblue commented Apr 10, 2017

We should also strip LOGGER statements I think, see https://bugzilla.mozilla.org/show_bug.cgi?id=1352486#c6 for some feedback from the Mozilla folks...

@chadhietala
Copy link
Member Author

@rwjblue should I merge this?

@rwjblue rwjblue merged commit eecdf90 into master Apr 18, 2017
@rwjblue rwjblue deleted the automated-builds branch April 18, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants