Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.8/pydantic2 #1368

Closed
wants to merge 16 commits into from
Closed

0.8/pydantic2 #1368

wants to merge 16 commits into from

Conversation

joernweissenborn
Copy link
Member

Better now than never.

@joernweissenborn joernweissenborn requested review from jsnel, a team and s-weigand as code owners October 17, 2023 21:21
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch joernweissenborn/pyglotaran/0.8/pydantic2

@joernweissenborn joernweissenborn changed the base branch from main to staging October 17, 2023 21:21
@sourcery-ai sourcery-ai bot mentioned this pull request Oct 17, 2023
Closed
@jsnel
Check if Factory is needed
d671497 
and update requirements_dev.txt so as to not get into CI trouble
@sourcery-ai sourcery-ai bot mentioned this pull request Oct 17, 2023
Closed
pre-commit-ci bot and others added 10 commits October 17, 2023 22:20
@s-weigand s-weigand marked this pull request as draft October 20, 2023 19:07
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
glotaran/builtin/elements/baseline/element.py 90.0% <100.0%> (ø)
glotaran/builtin/elements/clp_guide/element.py 100.0% <100.0%> (ø)
...aran/builtin/elements/coherent_artifact/element.py 77.2% <100.0%> (+0.2%) ⬆️
...ran/builtin/elements/damped_oscillation/element.py 94.3% <100.0%> (+<0.1%) ⬆️
glotaran/builtin/elements/kinetic/element.py 89.7% <100.0%> (+0.1%) ⬆️
glotaran/builtin/elements/spectral/element.py 85.0% <100.0%> (ø)
glotaran/io/preprocessor/preprocessor.py 100.0% <100.0%> (ø)
glotaran/model/data_model.py 87.7% <100.0%> (+0.1%) ⬆️
glotaran/model/experiment_model.py 100.0% <100.0%> (ø)
glotaran/optimization/optimization.py 78.0% <100.0%> (+0.3%) ⬆️
... and 8 more

📢 Thoughts on this report? Let us know!.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s-weigand s-weigand mentioned this pull request Oct 20, 2023
Merged
@s-weigand
Copy link
Member

Closing in favor of #1378 so @joernweissenborn can review the changes I made

@s-weigand s-weigand closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnel jsnel Awaiting requested review from jsnel jsnel is a code owner

@s-weigand s-weigand Awaiting requested review from s-weigand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joernweissenborn @s-weigand @jsnel