⬆️ 0.8/pydantic2 fix #1378
Merged
⬆️ 0.8/pydantic2 fix #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-weigand
requested review from
jsnel,
a team and
joernweissenborn
as code owners
|
|
Closed
s-weigand
commented
Oct 20, 2023
| @@ -38,6 +38,34 @@ | |||
| META_VALIDATOR = "__glotaran_validator__" | |||
|
|
|||
|
|
|||
| class GlotaranFieldMetadata(UserDict): | |||
There was a problem hiding this comment.
I know this whole thing isn't really pretty but we need to it keeps us going for now until we reevaluate the need for an extra evaluation mechanism.
s-weigand
force-pushed
the
0.8/pydantic2-fix
branch
from
e0fe6b4 to
ebe23ac
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
|
We still need to deal with But those are for a different discussion and PR 😅 |
and update requirements_dev.txt so as to not get into CI trouble
for more information, see https://pre-commit.ci
Without the type annotation it is omitted from the fields
s-weigand
force-pushed
the
0.8/pydantic2-fix
branch
from
ebe23ac to
0d03073
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jsnel
added a commit
to jsnel/pyglotaran
that referenced
this pull request
Jun 2, 2024
Various fixes related to the pydantic1 to pydantic2 upgrade. Some details: * Autoconvert to pydantic 2. * Replace missing clasing with any. * Adapted typing for pydantic 2. * Check if Factory is needed and update requirements_dev.txt so as to not get into CI trouble * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🩹 Fix assignment of literal type to type attribute * 🩹 Use RootModel instead of BaseModel and __root__ * 🩹 Replace deprecated parse_obj with model_validate * 🩹 Fix accessing of element data_model_type * 🩹 Undefined -> PydanticUndefined * 🩹 Adjust to removal of ModelField https://docs.pydantic.dev/latest/migration/#changes-to-validators-allowed-signatures * 🧪🩹 Adapt to schema changes * 🧪🩹 Fix pydantic validation error in test * 🧪🩹 Fix definition MockElementWithDataModel.data_model_type Without the type annotation it is omitted from the fields * 🧹 Replace .dict with .model_dump * 🧹 Replace .copy with .model_copy * 🤖 Refactored by Sourcery --------- Co-authored-by: Joern Weissenborn <joern.weissenborn@gmail.com> Co-authored-by: Joris Snellenburg <jsnel@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sourcery AI <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1368 but I made a separate PR so @joernweissenborn can review my changes.
Upgrading to pydantic 2 is the first step we need to take before we can make schema generation work.