-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validationresponse ticket close #18380
Fix validationresponse ticket close #18380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure we should accept answer to validation requests once a ticket is closed.
Yes, I forgot to mention this in the description, but I've deactivated it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK, you just need to take Change
into account.
Also, the new behaviors could be tested.
7b06e6a
to
950bc74
Compare
950bc74
to
b37c7cf
Compare
Checklist before requesting a review
Please delete options that are not relevant.
Description
When the ticket is closed and there are validation requests waiting for a response, it is still possible to validate them, but this does not update the global status.
So I deactivated the possibility of accepting a validation request once the ticket has been closed.
Screenshots (if appropriate):
Before
After