Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validationresponse ticket close #18380

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Nov 25, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35135
  • Here is a brief description of what this PR does

When the ticket is closed and there are validation requests waiting for a response, it is still possible to validate them, but this does not update the global status.

So I deactivated the possibility of accepting a validation request once the ticket has been closed.

Screenshots (if appropriate):

Before
image

After
image

@Lainow Lainow changed the base branch from main to 10.0/bugfixes November 25, 2024 13:21
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should accept answer to validation requests once a ticket is closed.

@cedric-anne cedric-anne requested a review from Rom1-B November 25, 2024 14:20
@Lainow
Copy link
Contributor Author

Lainow commented Nov 25, 2024

I am not sure we should accept answer to validation requests once a ticket is closed.

Yes, I forgot to mention this in the description, but I've deactivated it now.

Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

Perhaps we should also exclude tickets closed on the “Tickets waiting for your approval” counter and its associated search:

image

EDIT: There are also native dashboard cards:

image

@Lainow Lainow requested a review from Rom1-B November 26, 2024 08:50
src/Dashboard/Provider.php Show resolved Hide resolved
src/CommonITILValidation.php Outdated Show resolved Hide resolved
Lainow and others added 2 commits November 27, 2024 14:48
@Lainow Lainow requested review from Rom1-B and cedric-anne December 2, 2024 08:09
src/CommonITILValidation.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from Rom1-B December 2, 2024 15:35
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, you just need to take Change into account.
Also, the new behaviors could be tested.

src/CommonITILValidation.php Outdated Show resolved Hide resolved
@Lainow Lainow force-pushed the fix-validationresponse-ticket-close branch from 7b06e6a to 950bc74 Compare December 3, 2024 13:11
@Lainow Lainow force-pushed the fix-validationresponse-ticket-close branch from 950bc74 to b37c7cf Compare December 3, 2024 13:13
front/ticket.form.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne added this to the 10.0.18 milestone Dec 3, 2024
@cedric-anne cedric-anne added the bug label Dec 3, 2024
@cedric-anne cedric-anne merged commit e8910bc into glpi-project:10.0/bugfixes Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants