Allow validating only unsolved ITIL #18604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
While working on #17215, I noticed one place where the search result link for tickets waiting for approval filtered to unsolved tickets only. Some of the issue reported in the bug report was fixed in #18380 but there was still an inconsistency. Instead of hiding the ability to validate closed tickets only, it seems like it makes sense to also block validating solved tickets and changes. Once something is solved, all actions should be considered finished so approvals are expected to happen before that. Once solved, it is just waiting for user validation that the fix worked or validation from technicians in the case of an Observed change.