fix: client-side state change triggered by update from backend #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an empty slices property is received from the backend, but the sliders property is not yet updated, the slider will add its default value to the slices list, thereby changing the state which gets synced back to the backend. Fixes: spacetelescope/jdaviz#446
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 90.50% 90.50%
=======================================
Files 83 83
Lines 3960 3960
=======================================
Hits 3584 3584
Misses 376 376 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty slices property is received from the backend, but
the sliders property is not yet updated, the slider will add its
default value to the slices list, thereby changing the state
which gets synced back to the backend.
Releted to: spacetelescope/jdaviz#446