Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosviz new "ghost": select one object, change layer properties, select a different object, flashing gets triggered #446

Closed
camipacifici opened this issue Feb 25, 2021 · 2 comments

Comments

@camipacifici
Copy link
Contributor

Testing the NIRISS parsers, I found a ghost. It gets triggered after changing the layer properties on one object and then switching to a different object.
It is shown in this video: https://stsci.box.com/s/l1csxxdrvqj9f71ysfcsy0jb2yzxgnxs

@astrofrog, @mariobuikhuizen, @maartenbreddels, maybe have ideas?

@mariobuikhuizen
Copy link
Collaborator

mariobuikhuizen commented Feb 26, 2021

At first I couldn't reproduce this issue, but I did see an error. While investigating the error I arrived at the same spot that was problematic with the update loop fixed in 95f3e8e. After checking out the commit before this merged Pr (#427), I could reproduce this issue, so updating to main will solve this.

I will look further into the error that is still being produced.

Minimal steps to reproduce the error:

  • Click on a row in the table
  • Click on the cog in the toolbar of top right viewer
  • Click on another row in the table

mariobuikhuizen added a commit to mariobuikhuizen/glue-jupyter that referenced this issue Feb 28, 2021
When an empty slices property is received from the backend, but
the sliders property is not yet updated, the slider will add its
default value to the slices list, thereby changing the state
which gets synced back to the backend.

Fixes: spacetelescope/jdaviz#446
mariobuikhuizen added a commit to mariobuikhuizen/glue-jupyter that referenced this issue Feb 28, 2021
When an empty slices property is received from the backend, but
the sliders property is not yet updated, the slider will add its
default value to the slices list, thereby changing the state
which gets synced back to the backend.

Fixes: spacetelescope/jdaviz#446
@maartenbreddels
Copy link
Collaborator

This should be fixed once glue-viz/glue-jupyter#211 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants