Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI tests to GH Actions with publishing workflow #17

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

dhomeier
Copy link
Contributor

Description

Replace Azure with GH Actions via reusable workflows from https://github.com/OpenAstronomy/github-actions-workflows, including a standard publishing workflow.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #17 (160636a) into main (08bda43) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 160636a differs from pull request most recent head 18b1150. Consider uploading reports for the commit 18b1150 to get more accurate results

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   85.78%   86.03%   +0.24%     
==========================================
  Files           8        8              
  Lines         401      401              
==========================================
+ Hits          344      345       +1     
+ Misses         57       56       -1     
Impacted Files Coverage Δ
glue_plotly/html_exporters/scatter2d.py 82.52% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bda43...18b1150. Read the comment docs.

@dhomeier dhomeier requested a review from astrofrog June 27, 2022 16:09
@dhomeier
Copy link
Contributor Author

Should publish get a test_command to run on the built wheel?

@astrofrog
Copy link
Member

Yes I think ideally we should do it as for glue-core, if at all possible

@dhomeier
Copy link
Contributor Author

Seems to work with the same setup. I have just opened glue-viz/glue#2308 to add the needs: tests there (with allowed_failures factored out, which is not needed here :) and also added the codecov.yml as used in astropy, to try and set just a minimal nonzero threshold. Apparently codecov is not required to pass, so that's not strictly necessary.
And also copying from the astropy setup here the initial run of codestyle before anything else is started; what do you think about that?

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running codestyle before the rest seems sensible to me - this looks good, thanks!

@astrofrog astrofrog merged commit 95e25e5 into glue-viz:main Aug 23, 2022
@dhomeier dhomeier added enhancement New feature or request no-changelog-entry-needed Skipped in automatic changelog generation labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-changelog-entry-needed Skipped in automatic changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants