Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests requirement to publish workflow in CI #2308

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

dhomeier
Copy link
Collaborator

Description

To let the publish job only run after all envs in tests have completed successfully; to allow this to actually happen added allowed_failures to the (mostly PySide2) envs that are failing or segfaulting more or less erratically.
Also adding a codecov.yml to keep it from failing at essentially zero changes (which is probably due rounding errors).

@dhomeier
Copy link
Collaborator Author

Dunno where codecov is still digging up 4 lines in a completely unmodified file... I'd not stopping publish however, so not that critical.
I've also tested a setup running codestyle first before anything else; might add that here as well.

@dhomeier dhomeier marked this pull request as ready for review June 30, 2022 14:36
@dhomeier
Copy link
Collaborator Author

@pllim do you have any experience with the coverage rounding settings to make it less strict?

@pllim
Copy link
Contributor

pllim commented Jun 30, 2022

@dhomeier , alas, no... Try ask on #infrastructure channel in Astropy Slack?

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes!

@dhomeier
Copy link
Collaborator Author

dhomeier commented Aug 8, 2022

Codestyle is fixed now, but there is a fresh failure on the Linux pyqt515 runs for all recent PRs. No idea why the

qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.

would have popped back up – afaics all the installed xcb/xkb packages are identical.
Can you see any change between image versions 20220619.1 and
20220729.1 that might be responsible for this @astrofrog?

@dhomeier dhomeier force-pushed the ci-publish-reqs branch 5 times, most recently from c82f6d3 to 06eeb62 Compare August 9, 2022 00:39
@dhomeier dhomeier merged commit f8c1e96 into glue-viz:main Aug 9, 2022
@dhomeier dhomeier added the no-changelog-entry-needed Skipped in Changelog generation label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Skipped in Changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants