-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests
requirement to publish workflow in CI
#2308
Conversation
Dunno where codecov is still digging up 4 lines in a completely unmodified file... I'd not stopping |
@pllim do you have any experience with the coverage rounding settings to make it less strict? |
@dhomeier , alas, no... Try ask on |
4428f64
to
26bb67a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if CI passes!
Codestyle is fixed now, but there is a fresh failure on the Linux
would have popped back up – afaics all the installed xcb/xkb packages are identical. |
c82f6d3
to
06eeb62
Compare
06eeb62
to
72c17d5
Compare
Description
To let the
publish
job only run after all envs intests
have completed successfully; to allow this to actually happen addedallowed_failures
to the (mostly PySide2) envs that are failing or segfaulting more or less erratically.Also adding a
codecov.yml
to keep it from failing at essentially zero changes (which is probably due rounding errors).